anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #12927] fix: add --no-config in rg args #14440

New Issue
Open
opened 2026-02-16 18:19:14 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:19:14 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/12927

State: open
Merged: No

What does this PR do?

fix #12925

the issue is that: grep tool inherits user ripgrep config, which can silently alter search results

this fix adds --no-config to the rg command args list used in

  • the grep tool used by llm
  • the ripgrep used by tui server

from the below provided ripgrep documentation and source code we can see that --no-config will make sure rg doesn't read the global configuration file
https://github.com/BurntSushi/ripgrep/blob/0a88cccd5188074de96f54a4b6b44a63971ac157/GUIDE.md?plain=1#L621C1-L625C8
https://github.com/BurntSushi/ripgrep/blob/0a88cccd5188074de96f54a4b6b44a63971ac157/crates/core/flags/parse.rs#L88C1-L91C6

How did you verify your code works?

these steps verifies that a global ripgreprc file still can't affect opencode tool call result output if --no-config is passed in the args

  1. i have created two files ripgreprc and testfile.txt
$ tree
.
├── ripgreprc
└── testfile.txt

1 directory, 2 files

$ cat ripgreprc
--max-columns=10

$ cat testfile.txt
AAAAAAAAAA_FINDME_this_text_is_after_column_10
  1. running opencode debug agent build --tool grep to see that tool execution
    output. we set RIPGREP_CONFIG_PATH to our ripgreprc. we can see that the tool call result output is stripped
$ RIPGREP_CONFIG_PATH="ripgreprc" opencode debug agent build --tool grep \
  --params '{"pattern":"FINDME","path":"/tmp/opencode-grep-test"}' | jq .result.output

## result output
"Found 1 matches\n/tmp/opencode-grep-test/testfile.txt:\n  Line 1: [Omitted long matching line]"
  1. we build a localcode with the changes (having --no-config set), and use the localcode to run the command again. we can see that the tool cal result output is not stripped
$ RIPGREP_CONFIG_PATH="ripgreprc" ~/code/tmp/opencode/packages/opencode/dist/opencode-darwin-arm64/bin/opencode \
  debug agent build --tool grep \
  --params '{"pattern":"FINDME","path":"/tmp/opencode-grep-test"}' | jq .result.output

## result output
"Found 1 matches\n/tmp/opencode-grep-test/testfile.txt:\n  Line 1: AAAAAAAAAA_FINDME_this_text_is_after_column_10"

similarly, this verifies that the ripgrep search used by TUI server can't be affected by global configuration if --no-config is passed in the args

$ tree
.
├── ripgreprc
└── testfile.txt

1 directory, 2 files

$ cat testfile.txt
AAAAAAAAAA_FINDME_this_text_is_after_column_10

$ cat ripgreprc
--invert-match

$ RIPGREP_CONFIG_PATH="ripgreprc" opencode debug rg search "FINDME"
[
  {
    "path": {
      "text": "ripgreprc"
    },
    "lines": {
      "text": "--invert-match\n"
    },
    "line_number": 1,
    "absolute_offset": 0,
    "submatches": []
  }
]

$ RIPGREP_CONFIG_PATH="ripgreprc" ~/code/tmp/opencode/packages/opencode/dist/opencode-darwin-arm64/bin/opencode \
  debug rg search "FINDME"                                                                                                     [
  {
    "path": {
      "text": "testfile.txt"
    },
    "lines": {
      "text": "AAAAAAAAAA_FINDME_this_text_is_after_column_10\n"
    },
    "line_number": 1,
    "absolute_offset": 0,
    "submatches": [
      {
        "match": {
          "text": "FINDME"
        },
        "start": 11,
        "end": 17
      }
    ]
  }
]
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/12927 **State:** open **Merged:** No --- ### What does this PR do? fix #12925 the issue is that: grep tool inherits user ripgrep config, which can silently alter search results this fix adds `--no-config` to the rg command args list used in - the grep tool used by llm - the ripgrep used by tui server from the below provided ripgrep documentation and source code we can see that `--no-config` will make sure `rg` doesn't read the global configuration file https://github.com/BurntSushi/ripgrep/blob/0a88cccd5188074de96f54a4b6b44a63971ac157/GUIDE.md?plain=1#L621C1-L625C8 https://github.com/BurntSushi/ripgrep/blob/0a88cccd5188074de96f54a4b6b44a63971ac157/crates/core/flags/parse.rs#L88C1-L91C6 ### How did you verify your code works? #### these steps verifies that a global ripgreprc file still can't affect opencode tool call result output if `--no-config` is passed in the args 1. i have created two files `ripgreprc` and `testfile.txt` ```bash $ tree . ├── ripgreprc └── testfile.txt 1 directory, 2 files $ cat ripgreprc --max-columns=10 $ cat testfile.txt AAAAAAAAAA_FINDME_this_text_is_after_column_10 ``` 2. running `opencode debug agent build --tool grep` to see that tool execution output. we set `RIPGREP_CONFIG_PATH` to our `ripgreprc`. we can see that the tool call result output is stripped ```bash $ RIPGREP_CONFIG_PATH="ripgreprc" opencode debug agent build --tool grep \ --params '{"pattern":"FINDME","path":"/tmp/opencode-grep-test"}' | jq .result.output ## result output "Found 1 matches\n/tmp/opencode-grep-test/testfile.txt:\n Line 1: [Omitted long matching line]" ``` 3. we build a localcode with the changes (having `--no-config` set), and use the localcode to run the command again. we can see that the tool cal result output is not stripped ```bash $ RIPGREP_CONFIG_PATH="ripgreprc" ~/code/tmp/opencode/packages/opencode/dist/opencode-darwin-arm64/bin/opencode \ debug agent build --tool grep \ --params '{"pattern":"FINDME","path":"/tmp/opencode-grep-test"}' | jq .result.output ## result output "Found 1 matches\n/tmp/opencode-grep-test/testfile.txt:\n Line 1: AAAAAAAAAA_FINDME_this_text_is_after_column_10" ``` #### similarly, this verifies that the ripgrep search used by TUI server can't be affected by global configuration if `--no-config` is passed in the args ```bash $ tree . ├── ripgreprc └── testfile.txt 1 directory, 2 files $ cat testfile.txt AAAAAAAAAA_FINDME_this_text_is_after_column_10 $ cat ripgreprc --invert-match $ RIPGREP_CONFIG_PATH="ripgreprc" opencode debug rg search "FINDME" [ { "path": { "text": "ripgreprc" }, "lines": { "text": "--invert-match\n" }, "line_number": 1, "absolute_offset": 0, "submatches": [] } ] $ RIPGREP_CONFIG_PATH="ripgreprc" ~/code/tmp/opencode/packages/opencode/dist/opencode-darwin-arm64/bin/opencode \ debug rg search "FINDME" [ { "path": { "text": "testfile.txt" }, "lines": { "text": "AAAAAAAAAA_FINDME_this_text_is_after_column_10\n" }, "line_number": 1, "absolute_offset": 0, "submatches": [ { "match": { "text": "FINDME" }, "start": 11, "end": 17 } ] } ] ```
yindo added the pull-request label 2026-02-16 18:19:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#14440
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?