anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-21 17:56:33 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #12983] refactor: clean up dialog-model.tsx per code review #14460

New Issue
Closed
opened 2026-02-16 18:19:15 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:19:15 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/12983

State: closed
Merged: Yes

Summary

  • Extract duplicated favorite/recent option builder into a toOptions helper (~30 lines of duplication removed)
  • Simplify showExtra memo from branching pattern to single boolean expression
  • Simplify title memo with optional chaining, removing double memo call and ! assertion
  • Remove dead ref signal and unused DialogSelectRef import
  • Inline intermediate variables (q, value aliases) per style guide
  • Use implicit returns in map callbacks for consistency
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/12983 **State:** closed **Merged:** Yes --- ## Summary - Extract duplicated favorite/recent option builder into a `toOptions` helper (~30 lines of duplication removed) - Simplify `showExtra` memo from branching pattern to single boolean expression - Simplify `title` memo with optional chaining, removing double memo call and `!` assertion - Remove dead `ref` signal and unused `DialogSelectRef` import - Inline intermediate variables (`q`, `value` aliases) per style guide - Use implicit returns in map callbacks for consistency
yindo added the pull-request label 2026-02-16 18:19:15 -05:00
yindo closed this issue 2026-02-16 18:19:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#14460
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?