anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #13021] fix(opencode): Allowing subagents to send tool permissions through the ACP correctly #14480

New Issue
Open
opened 2026-02-16 18:19:16 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:19:16 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/13021

State: open
Merged: No

Closes #12133

What does this PR do?

Forwards tool approval requests from subagents through the ACP connection. Does so by backtracking up the agent "callstack" until we find an agent session that is registered as an ACP. We then use that as the notification ID for tool approvals.

How did you verify your code works?

Ran a task that does a tool call in CodeCompanion.nvim using OpenCode ACP. Also ran a task that ran a task that did a tool call. Both asked for approval correctly and did not hang.

I saw after making this https://github.com/anomalyco/opencode/pull/12136, but keeping mine here as it is able to handle infinitely nested subagent chains.

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/13021 **State:** open **Merged:** No --- Closes #12133 ### What does this PR do? Forwards tool approval requests from subagents through the ACP connection. Does so by backtracking up the agent "callstack" until we find an agent session that is registered as an ACP. We then use that as the notification ID for tool approvals. ### How did you verify your code works? Ran a task that does a tool call in CodeCompanion.nvim using OpenCode ACP. Also ran a task that ran a task that did a tool call. Both asked for approval correctly and did not hang. I saw after making this https://github.com/anomalyco/opencode/pull/12136, but keeping mine here as it is able to handle infinitely nested subagent chains.
yindo added the pull-request label 2026-02-16 18:19:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#14480
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?