anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-21 17:56:33 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #13034] test(compaction): failing tests for missing headroom when limit.input is set #14486

New Issue
Closed
opened 2026-02-16 18:19:16 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:19:16 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/13034

State: closed
Merged: Yes

Relates to #10634

adds 3 failing tests showing that isOverflow() doesn't reserve any headroom when limit.input is set, unlike the context - output fallback path.

basically if you have a model with limit.input = 200K and you've used 198K tokens, isOverflow says you're fine. next turn overflows.

without limit.input, same scenario correctly triggers compaction because it uses context - output (168K).

the diff between the two paths is exactly 32K — the output budget that's not being subtracted.

was hitting this with claude models in our tui project and traced it to line 37 in compaction.ts. saw #6875 and #12924 are both trying to fix this — these tests should pass once either lands.

related: #10634 #8089 #11086

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/13034 **State:** closed **Merged:** Yes --- Relates to #10634 adds 3 failing tests showing that `isOverflow()` doesn't reserve any headroom when `limit.input` is set, unlike the `context - output` fallback path. basically if you have a model with `limit.input = 200K` and you've used 198K tokens, `isOverflow` says you're fine. next turn overflows. without `limit.input`, same scenario correctly triggers compaction because it uses `context - output` (168K). the diff between the two paths is exactly 32K — the output budget that's not being subtracted. was hitting this with claude models in our tui project and traced it to line 37 in compaction.ts. saw #6875 and #12924 are both trying to fix this — these tests should pass once either lands. related: #10634 #8089 #11086
yindo added the pull-request label 2026-02-16 18:19:16 -05:00
yindo closed this issue 2026-02-16 18:19:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#14486
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?