anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #13082] fix: encode non-ASCII directory path in v1 SDK client header #14507

New Issue
Open
opened 2026-02-16 18:19:18 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:19:18 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/13082

State: open
Merged: No

Problem

The v1 SDK client (packages/sdk/js/src/client.ts) passes the directory path directly to the x-opencode-directory HTTP header without encoding. When the path contains non-ASCII characters (Chinese, Japanese, Korean, etc.), the runtime's strict header validation rejects the value, causing a crash:

TypeError: Header x-opencode-directory has invalid value: C:\Users\baode\OneDrive\桌面

This is a regression introduced in v1.1.54+. Multiple users on Windows, macOS, and Linux are affected.

Root Cause

The v2 SDK client already has the fix (added isNonASCII detection + encodeURIComponent), but the v1 SDK client was missed.

The server already handles decoding via decodeURIComponent (server.ts:200), so only the client-side encoding is needed.

Fix

Apply the same encoding logic from v2 client to v1 client:

if (config?.directory) {
  const isNonASCII = /[^\x00-\x7F]/.test(config.directory)
  const encodedDirectory = isNonASCII ? encodeURIComponent(config.directory) : config.directory
  config.headers = {
    ...config.headers,
    "x-opencode-directory": encodedDirectory,
  }
}

Testing

  • ASCII paths: no behavior change (bypass encoding)
  • Non-ASCII paths (Chinese/Japanese/Korean): encoded via encodeURIComponent, decoded server-side via existing decodeURIComponent

Fixes #13023

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/13082 **State:** open **Merged:** No --- ## Problem The v1 SDK client (`packages/sdk/js/src/client.ts`) passes the directory path directly to the `x-opencode-directory` HTTP header without encoding. When the path contains non-ASCII characters (Chinese, Japanese, Korean, etc.), the runtime's strict header validation rejects the value, causing a crash: ``` TypeError: Header x-opencode-directory has invalid value: C:\Users\baode\OneDrive\桌面 ``` This is a regression introduced in v1.1.54+. Multiple users on Windows, macOS, and Linux are affected. ## Root Cause The v2 SDK client already has the fix (added `isNonASCII` detection + `encodeURIComponent`), but the v1 SDK client was missed. The server already handles decoding via `decodeURIComponent` (`server.ts:200`), so only the client-side encoding is needed. ## Fix Apply the same encoding logic from v2 client to v1 client: ```typescript if (config?.directory) { const isNonASCII = /[^\x00-\x7F]/.test(config.directory) const encodedDirectory = isNonASCII ? encodeURIComponent(config.directory) : config.directory config.headers = { ...config.headers, "x-opencode-directory": encodedDirectory, } } ``` ## Testing - ASCII paths: no behavior change (bypass encoding) - Non-ASCII paths (Chinese/Japanese/Korean): encoded via `encodeURIComponent`, decoded server-side via existing `decodeURIComponent` Fixes #13023
yindo added the pull-request label 2026-02-16 18:19:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#14507
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?