anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 18:25:32 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #13095] fix(opencode): ACP sessions never get LLM-generated titles #14509

New Issue
Closed
opened 2026-02-16 18:19:18 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:19:18 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/13095

State: closed
Merged: Yes

fixes #11442

What does this PR do?

ACP sessions always have titles like "ACP Session <UUID>" instead of getting LLM-generated titles like TUI sessions do.
The root cause is in packages/opencode/src/acp/session.ts — when creating a new session, the title is hardcoded:

const session = await this.sdk.session.create({
  title: `ACP Session ${crypto.randomUUID()}`,
  directory: cwd,
}, { throwOnError: true })

After the first prompt, ensureTitle() in session/prompt.ts is supposed to ask the LLM for a proper title. But it first checks Session.isDefaultTitle(), which only recognizes "New session - <date>" and "Child session - <date>" as default titles.

Since "ACP Session ..." doesn't match either pattern, ensureTitle bails immediately and the hardcoded title sticks forever.

The fix removes the explicit title field from the session.create() call. Without it, the session falls through to createDefaultTitle() which produces "New session - <date>" — a format isDefaultTitle() recognizes. Then ensureTitle() works as intended and replaces it with an LLM-generated title after the first exchange.

How did you verify your code works?

  1. tsgo --noEmit on packages/opencode/ passes with zero errors
  2. Started opencode, created an ACP session via session/create, sent a prompt via message/create, then checked session/list — the session initially shows "New session - <date>" and after the first response completes, ensureTitle kicks in and replaces it with an LLM-generated title
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/13095 **State:** closed **Merged:** Yes --- fixes #11442 ### What does this PR do? ACP sessions always have titles like `"ACP Session <UUID>"` instead of getting LLM-generated titles like TUI sessions do. The root cause is in `packages/opencode/src/acp/session.ts` — when creating a new session, the title is hardcoded: ```ts const session = await this.sdk.session.create({ title: `ACP Session ${crypto.randomUUID()}`, directory: cwd, }, { throwOnError: true }) ``` After the first prompt, `ensureTitle()` in `session/prompt.ts` is supposed to ask the LLM for a proper title. But it first checks `Session.isDefaultTitle()`, which only recognizes `"New session - <date>"` and `"Child session - <date>"` as default titles. Since `"ACP Session ..."` doesn't match either pattern, `ensureTitle` bails immediately and the hardcoded title sticks forever. The fix removes the explicit `title` field from the `session.create()` call. Without it, the session falls through to `createDefaultTitle()` which produces `"New session - <date>"` — a format `isDefaultTitle()` recognizes. Then `ensureTitle()` works as intended and replaces it with an LLM-generated title after the first exchange. ### How did you verify your code works? 1. `tsgo --noEmit` on `packages/opencode/` passes with zero errors 2. Started opencode, created an ACP session via `session/create`, sent a prompt via `message/create`, then checked `session/list` — the session initially shows `"New session - <date>"` and after the first response completes, `ensureTitle` kicks in and replaces it with an LLM-generated title
yindo added the pull-request label 2026-02-16 18:19:18 -05:00
yindo closed this issue 2026-02-16 18:19:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#14509
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?