anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 10:15:31 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #13106] fix(edit): unescape newString replacements to avoid literal \\n #14513

New Issue
Open
opened 2026-02-16 18:19:18 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:19:18 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/13106

State: open
Merged: No

What does this PR do?

Fixes #3545.

edit currently unescapes matching for oldString but writes newString directly. Some providers send newString with escaped \\n, which can cause literal \n to be written to files.

Changes:

  • move unescapeString to a shared helper in packages/opencode/src/tool/edit.ts
  • apply unescape to replacement text in replace(...)
  • apply unescape in the oldString === "" write path
  • add regression tests in packages/opencode/test/tool/edit.test.ts

How did you verify your code works?

  • Added regression tests for:
    • escaped newline replacement
    • replaceAll path
    • double-escaped \\\\n remaining literal when intended
  • GitHub Actions passed on this PR:
    • typecheck
    • unit (linux)
    • e2e (linux)
    • e2e (windows)
    • test (linux)
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/13106 **State:** open **Merged:** No --- ### What does this PR do? Fixes #3545. `edit` currently unescapes matching for `oldString` but writes `newString` directly. Some providers send `newString` with escaped `\\n`, which can cause literal `\n` to be written to files. Changes: - move `unescapeString` to a shared helper in `packages/opencode/src/tool/edit.ts` - apply unescape to replacement text in `replace(...)` - apply unescape in the `oldString === ""` write path - add regression tests in `packages/opencode/test/tool/edit.test.ts` ### How did you verify your code works? - Added regression tests for: - escaped newline replacement - `replaceAll` path - double-escaped `\\\\n` remaining literal when intended - GitHub Actions passed on this PR: - `typecheck` - `unit (linux)` - `e2e (linux)` - `e2e (windows)` - `test (linux)`
yindo added the pull-request label 2026-02-16 18:19:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#14513
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?