anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-23 10:45:33 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #13253] fix(test): clean up pending Question promises to prevent unhandled rejections #14584

New Issue
Open
opened 2026-02-16 18:19:22 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:19:22 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/13253

State: open
Merged: No

Summary

Fixes CI failure caused by unhandled promise rejections in question tests.

Root cause

question.test.ts created pending Question.ask() promises without .catch() and without disposing the test Instance. Later Instance.disposeAll() rejected those orphaned promises, producing Unhandled error between tests (The user dismissed this question).

Changes

  • Add .catch(() => {}) to pending Question.ask() promises in affected tests
  • Add await Instance.dispose() cleanup in those tests

Validation

  • bun test test/question/question.test.ts test/memory/dispose.test.ts in packages/opencode: 17 pass / 0 fail
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/13253 **State:** open **Merged:** No --- ## Summary Fixes CI failure caused by unhandled promise rejections in question tests. ## Root cause `question.test.ts` created pending `Question.ask()` promises without `.catch()` and without disposing the test `Instance`. Later `Instance.disposeAll()` rejected those orphaned promises, producing `Unhandled error between tests` (`The user dismissed this question`). ## Changes - Add `.catch(() => {})` to pending `Question.ask()` promises in affected tests - Add `await Instance.dispose()` cleanup in those tests ## Validation - `bun test test/question/question.test.ts test/memory/dispose.test.ts` in `packages/opencode`: **17 pass / 0 fail**
yindo added the pull-request label 2026-02-16 18:19:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#14584
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?