anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #13321] fix: robust subagent completion propagation #14612

New Issue
Open
opened 2026-02-16 18:19:23 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:19:23 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/13321

State: open
Merged: No

Summary

Fixes parent session hanging indefinitely when a subagent (Task tool) completes but SessionPrompt.prompt() never resolves. Fixes #9003, #10802, #11865, #6792.

Three targeted changes:

  1. await the prune() call (prompt.ts:653) — was fire-and-forget, racing with the immediately following MessageV2.stream() reads.
  2. Diagnostic logging (prompt.ts:305-312) — the loop exit condition silently continued when assistant finished but user message ID was newer. Now logs a warning so this case is visible.
  3. Event-driven recovery (task.ts) — subscribe to child MessageV2.Event.Updated; if the child reaches a terminal state (finish or error) but the prompt doesn't resolve within 3s, force-cancel to unblock the parent. Not a timeout — only fires with positive proof of completion.
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/13321 **State:** open **Merged:** No --- ## Summary Fixes parent session hanging indefinitely when a subagent (Task tool) completes but `SessionPrompt.prompt()` never resolves. Fixes #9003, #10802, #11865, #6792. Three targeted changes: 1. **`await` the `prune()` call** (`prompt.ts:653`) — was fire-and-forget, racing with the immediately following `MessageV2.stream()` reads. 2. **Diagnostic logging** (`prompt.ts:305-312`) — the loop exit condition silently continued when assistant finished but user message ID was newer. Now logs a warning so this case is visible. 3. **Event-driven recovery** (`task.ts`) — subscribe to child `MessageV2.Event.Updated`; if the child reaches a terminal state (finish or error) but the prompt doesn't resolve within 3s, force-cancel to unblock the parent. Not a timeout — only fires with positive proof of completion.
yindo added the pull-request label 2026-02-16 18:19:23 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#14612
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?