anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #13408] fix(opencode): coerce custom tool output to string before processing #14651

New Issue
Open
opened 2026-02-16 18:19:25 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:19:25 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/13408

State: open
Merged: No

What does this PR do?

Fixes #13365

Custom tools that return non-string values (numbers, objects) crash with TypeError: text2.split is not a function. The fromPlugin wrapper in registry.ts passes the raw result from def.execute() directly to Truncate.output(), which calls .split("\n") on it — that blows up when the value isn't a string.

Now the result gets coerced to a string (JSON.stringify for non-strings) before hitting truncation or being stored as output.

How did you verify your code works?

Traced the call chain from fromPlugin → Truncate.output → .split("\n") and confirmed the crash path. Added a test for Truncate.output with string inputs. bun typecheck and bun turbo test both pass (only pre-existing Bedrock timeout failures).

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/13408 **State:** open **Merged:** No --- ### What does this PR do? Fixes #13365 Custom tools that return non-string values (numbers, objects) crash with `TypeError: text2.split is not a function`. The `fromPlugin` wrapper in `registry.ts` passes the raw result from `def.execute()` directly to `Truncate.output()`, which calls `.split("\n")` on it — that blows up when the value isn't a string. Now the result gets coerced to a string (`JSON.stringify` for non-strings) before hitting truncation or being stored as output. ### How did you verify your code works? Traced the call chain from `fromPlugin` → `Truncate.output` → `.split("\n")` and confirmed the crash path. Added a test for `Truncate.output` with string inputs. `bun typecheck` and `bun turbo test` both pass (only pre-existing Bedrock timeout failures).
yindo added the pull-request label 2026-02-16 18:19:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#14651
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?