anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 10:15:31 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #13417] fix(opencode): preserve custom tool arg descriptions in LLM prompts #14656

New Issue
Open
opened 2026-02-16 18:19:26 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:19:26 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/13417

State: open
Merged: No

What does this PR do?

Fixes #4357

Custom tool .describe() metadata on args wasn't making it into the prompts sent to providers. prompt.ts was using z.toJSONSchema() to convert Zod schemas, but that method drops descriptions from dynamically imported schemas. experimental.ts already uses zodToJsonSchema() from zod-to-json-schema which handles this correctly — this just makes prompt.ts consistent.

How did you verify your code works?

bun typecheck passes. Confirmed the z.toJSONSchema call is gone and replaced with zodToJsonSchema which already works correctly in experimental.ts.

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/13417 **State:** open **Merged:** No --- ### What does this PR do? Fixes #4357 Custom tool `.describe()` metadata on args wasn't making it into the prompts sent to providers. `prompt.ts` was using `z.toJSONSchema()` to convert Zod schemas, but that method drops descriptions from dynamically imported schemas. `experimental.ts` already uses `zodToJsonSchema()` from `zod-to-json-schema` which handles this correctly — this just makes `prompt.ts` consistent. ### How did you verify your code works? `bun typecheck` passes. Confirmed the `z.toJSONSchema` call is gone and replaced with `zodToJsonSchema` which already works correctly in `experimental.ts`.
yindo added the pull-request label 2026-02-16 18:19:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#14656
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?