anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #13502] fix: retry on timeout errors instead of failing #14691

New Issue
Open
opened 2026-02-16 18:19:27 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:19:27 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/13502

State: open
Merged: No

Fixes #13138

Problem

When provider requests timeout (default 5 min), AbortSignal.timeout() throws a DOMException with name: 'TimeoutError'. This error was not handled in fromError(), causing it to fall through to Unknown error type which is not retryable. Sessions stopped immediately instead of retrying.

Solution

Handle TimeoutError DOMException in fromError() and convert it to APIError with isRetryable: true. This enables automatic retry with exponential backoff via the existing retry mechanism.

Testing

Verified the fix handles timeout errors correctly. The session will now retry on provider timeouts instead of failing immediately.

Related issues/PRs (not duplicates):

  • #7929 - AbortSignal.timeout is not a function (missing API on Windows/web)
  • #12762 - Bash tool timeout config being ignored
  • #8633 / #8630 - MCP timeout configuration
  • #13189 - Model fallback with TTFT-based timeout
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/13502 **State:** open **Merged:** No --- Fixes #13138 ## Problem When provider requests timeout (default 5 min), `AbortSignal.timeout()` throws a `DOMException` with `name: 'TimeoutError'`. This error was not handled in `fromError()`, causing it to fall through to `Unknown` error type which is not retryable. Sessions stopped immediately instead of retrying. ## Solution Handle `TimeoutError` DOMException in `fromError()` and convert it to `APIError` with `isRetryable: true`. This enables automatic retry with exponential backoff via the existing retry mechanism. ## Testing Verified the fix handles timeout errors correctly. The session will now retry on provider timeouts instead of failing immediately. --- **Related issues/PRs (not duplicates):** - #7929 - `AbortSignal.timeout is not a function` (missing API on Windows/web) - #12762 - Bash tool timeout config being ignored - #8633 / #8630 - MCP timeout configuration - #13189 - Model fallback with TTFT-based timeout
yindo added the pull-request label 2026-02-16 18:19:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#14691
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?