anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #13696] fix(opencode): stop overwriting manual model selection on agent data refresh #14778

New Issue
Open
opened 2026-02-16 18:19:32 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:19:32 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/13696

State: open
Merged: No

Summary

Fixes #13456

Remove the createEffect in local.tsx that enforced the agent's default model whenever agent state was refreshed by the server. This effect was redundant and caused user-selected models to silently revert to the agent's default on every server sync.

Problem

When a user manually selects a different model in the TUI model switcher, a createEffect (L384-400) tracks agent.current() and overwrites the selection with the agent's configured default. This fires not only on agent switches but on any server sync that updates agent data — silently replacing the user's choice.

Root Cause

The createEffect at local.tsx:384-400 tracks the full agent.current() reactive object. When sync.data.agent is reconciled during server bootstrap or instance disposal events, the effect re-runs and calls model.set() with the agent's default model, overwriting whatever the user had manually selected.

Why Removing the Effect is Safe

The currentModel memo (L196-205) already handles all fallback cases through its priority chain:

  1. modelStore.model[agentName] — user's manual per-agent selection (set by model.set())
  2. agent.model — agent's configured default
  3. fallbackModel — CLI --model arg / config file / recent list / first available provider
Scenario Without Effect With Effect (current bug)
Startup, no manual selection Falls to agent default ✅ Sets agent default ✅
User selects Model X Uses Model X ✅ Uses Model X ✅
Server sync fires Keeps Model X ✅ Reverts to default 🐛
Switch to different agent Falls to that agent's default ✅ Sets that agent's default ✅
Switch back to original agent Restores Model X ✅ Loses Model X 🐛

Changes

  • Remove createEffect that overwrote model selection on agent data refresh
  • Remove unused createEffect import

How to Verify

  1. Launch TUI, select a non-default model via the model switcher
  2. Send a message (triggers server sync)
  3. Verify the selected model persists and is not reverted to the agent's default
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/13696 **State:** open **Merged:** No --- ## Summary Fixes #13456 Remove the `createEffect` in `local.tsx` that enforced the agent's default model whenever agent state was refreshed by the server. This effect was redundant and caused user-selected models to silently revert to the agent's default on every server sync. ## Problem When a user manually selects a different model in the TUI model switcher, a `createEffect` (L384-400) tracks `agent.current()` and overwrites the selection with the agent's configured default. This fires not only on agent switches but on **any** server sync that updates agent data — silently replacing the user's choice. ## Root Cause The `createEffect` at `local.tsx:384-400` tracks the full `agent.current()` reactive object. When `sync.data.agent` is reconciled during server bootstrap or instance disposal events, the effect re-runs and calls `model.set()` with the agent's default model, overwriting whatever the user had manually selected. ## Why Removing the Effect is Safe The `currentModel` memo (L196-205) already handles all fallback cases through its priority chain: 1. **`modelStore.model[agentName]`** — user's manual per-agent selection (set by `model.set()`) 2. **`agent.model`** — agent's configured default 3. **`fallbackModel`** — CLI `--model` arg / config file / recent list / first available provider | Scenario | Without Effect | With Effect (current bug) | |----------|---------------|--------------------------| | Startup, no manual selection | Falls to agent default ✅ | Sets agent default ✅ | | User selects Model X | Uses Model X ✅ | Uses Model X ✅ | | **Server sync fires** | **Keeps Model X** ✅ | **Reverts to default** 🐛 | | Switch to different agent | Falls to that agent's default ✅ | Sets that agent's default ✅ | | Switch back to original agent | **Restores Model X** ✅ | **Loses Model X** 🐛 | ## Changes - Remove `createEffect` that overwrote model selection on agent data refresh - Remove unused `createEffect` import ## How to Verify 1. Launch TUI, select a non-default model via the model switcher 2. Send a message (triggers server sync) 3. Verify the selected model persists and is not reverted to the agent's default
yindo added the pull-request label 2026-02-16 18:19:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#14778
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?