anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #13699] fix: run JSON session migration for incremental upgrades #14780

New Issue
Open
opened 2026-02-16 18:19:32 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:19:32 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/13699

State: open
Merged: No

Summary

Fixes #13654.

The JSON->SQLite migration gate currently checks for opencode.db. That fails for incremental upgrades because the DB can exist from earlier schema migrations, so legacy JSON sessions never get imported.

This PR switches the gate to a dedicated migration marker:

  • run migration when storage/ exists and json-sqlite-migration-complete is missing
  • write the marker after migration completes
  • keep migration logic unchanged otherwise

Why this fixes it

Users who already have opencode.db but still have legacy JSON session files will now run the import once and recover old sessions.

Testing

  • ~/.bun/bin/bun test test/storage/json-migration.test.ts
  • ~/.bun/bin/bun test test/storage/json-migration.test.ts --coverage
  • Added tests for migration gating behavior:
    • storage exists + marker missing -> runs
    • marker exists -> skips
    • storage missing -> skips
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/13699 **State:** open **Merged:** No --- ## Summary Fixes #13654. The JSON->SQLite migration gate currently checks for `opencode.db`. That fails for incremental upgrades because the DB can exist from earlier schema migrations, so legacy JSON sessions never get imported. This PR switches the gate to a dedicated migration marker: - run migration when `storage/` exists and `json-sqlite-migration-complete` is missing - write the marker after migration completes - keep migration logic unchanged otherwise ## Why this fixes it Users who already have `opencode.db` but still have legacy JSON session files will now run the import once and recover old sessions. ## Testing - `~/.bun/bin/bun test test/storage/json-migration.test.ts` - `~/.bun/bin/bun test test/storage/json-migration.test.ts --coverage` - Added tests for migration gating behavior: - storage exists + marker missing -> runs - marker exists -> skips - storage missing -> skips
yindo added the pull-request label 2026-02-16 18:19:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#14780
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?