anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 18:25:32 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

no check if unzip is installed #1523

New Issue
Open
opened 2026-02-16 17:31:22 -05:00 by yindo · 11 comments
yindo commented 2026-02-16 17:31:22 -05:00
Owner
Copy Link
Copy Source

Originally created by @iislamgom3a on GitHub (Aug 28, 2025).

Originally assigned to: @thdxr on GitHub.

Image
Originally created by @iislamgom3a on GitHub (Aug 28, 2025). Originally assigned to: @thdxr on GitHub. <img width="917" height="101" alt="Image" src="https://github.com/user-attachments/assets/bcd701c8-0f95-496d-b4f9-e3fc4138e634" />
yindo commented 2026-02-16 17:31:23 -05:00
Author
Owner
Copy Link
Copy Source

@github-actions[bot] commented on GitHub (Aug 28, 2025):

This issue might be a duplicate of existing issues. Please check:

  • #967: This issue specifically addresses replacing the external unzip dependency with PowerShell's built-in extraction capabilities to eliminate the 'choco install unzip' dependency requirement

Feel free to ignore if none of these address your specific case.

@github-actions[bot] commented on GitHub (Aug 28, 2025): This issue might be a duplicate of existing issues. Please check: - #967: This issue specifically addresses replacing the external unzip dependency with PowerShell's built-in extraction capabilities to eliminate the 'choco install unzip' dependency requirement Feel free to ignore if none of these address your specific case.
yindo commented 2026-02-16 17:31:23 -05:00
Author
Owner
Copy Link
Copy Source

@vickywane commented on GitHub (Sep 22, 2025):

@rekram1-node I'd love to work on this.

Should unzip be automatically installed if not found?

Cc: @thdxr

@vickywane commented on GitHub (Sep 22, 2025): @rekram1-node I'd love to work on this. Should unzip be automatically installed if not found? Cc: @thdxr
yindo commented 2026-02-16 17:31:23 -05:00
Author
Owner
Copy Link
Copy Source

@rekram1-node commented on GitHub (Sep 22, 2025):

@vickywane Instead of automatically installing unzip, I'm thinking we should fall back to using tar when unzip isn't available.

@rekram1-node commented on GitHub (Sep 22, 2025): @vickywane Instead of automatically installing unzip, I'm thinking we should fall back to using tar when unzip isn't available.
yindo commented 2026-02-16 17:31:23 -05:00
Author
Owner
Copy Link
Copy Source

@vickywane commented on GitHub (Sep 22, 2025):

Okay, that sounds like a good idea.

I can work on a PR to implement that.

@vickywane commented on GitHub (Sep 22, 2025): Okay, that sounds like a good idea. I can work on a PR to implement that.
yindo commented 2026-02-16 17:31:23 -05:00
Author
Owner
Copy Link
Copy Source

@vickywane commented on GitHub (Oct 12, 2025):

@rekram1-node I've fixed this in this PR

@vickywane commented on GitHub (Oct 12, 2025): @rekram1-node I've fixed this in this [PR](https://github.com/sst/opencode/pull/3110)
yindo commented 2026-02-16 17:31:23 -05:00
Author
Owner
Copy Link
Copy Source

@rekram1-node commented on GitHub (Oct 12, 2025):

@vickywane btw your fix doesn't fix this issue unfortunately

This is an issue w/ the install script, I was saying it should fall back to tar (if it doesn't, maybe this was fixed since issue was made): https://github.com/sst/opencode/blob/afb406c5ff4fddfa18239b290a5a3f568bf0ed63/install#L97

For what you did in your PR that is actually really good BUT we need to actually do a slightly different solution for windows compat

We actually have a separate issue tracking what you tried to fix: https://github.com/sst/opencode/issues/967

We want to replace all unzip invocations in lsp install with zip js

@rekram1-node commented on GitHub (Oct 12, 2025): @vickywane btw your fix doesn't fix this issue unfortunately This is an issue w/ the install script, I was saying it should fall back to tar (if it doesn't, maybe this was fixed since issue was made): https://github.com/sst/opencode/blob/afb406c5ff4fddfa18239b290a5a3f568bf0ed63/install#L97 For what you did in your PR that is actually really good BUT we need to actually do a slightly different solution for windows compat We actually have a separate issue tracking what you tried to fix: https://github.com/sst/opencode/issues/967 We want to replace all unzip invocations in lsp install with zip js
yindo commented 2026-02-16 17:31:23 -05:00
Author
Owner
Copy Link
Copy Source

@vickywane commented on GitHub (Oct 12, 2025):

Oh, I see @rekram1-node

I just went through the link issue, and I don't think it's fixed. ( The PR was closed.)

If the expectation is to use zip.js, would it be safe to assume it'll be used for both Windows and Unix platforms? Would you also like me to continue with the PR to achieve this?

@vickywane commented on GitHub (Oct 12, 2025): Oh, I see @rekram1-node I just went through the link issue, and I don't think it's fixed. ( The PR was closed.) If the expectation is to use [zip.js](https://gildas-lormeau.github.io/zip.js), would it be safe to assume it'll be used for both Windows and Unix platforms? Would you also like me to continue with the PR to achieve this?
yindo commented 2026-02-16 17:31:23 -05:00
Author
Owner
Copy Link
Copy Source

@rekram1-node commented on GitHub (Oct 12, 2025):

yes @vickywane that pr was closed because the llm didnt understand the goal haha

And yes using zipjs is compatible on both platforms

Btw dont feel pressured to open a pr but if you are happy to ill give some guidance:

  • we already use zipjs in a few other places
  • when using zipjs with the lsps be careful to preserve symlinks and things
  • should be pretty easy to test the changes:

clear the bin dir that lsps are installed in then:
bun run dev debug lsp diagnostics

^ should install lsp if not installed

@rekram1-node commented on GitHub (Oct 12, 2025): yes @vickywane that pr was closed because the llm didnt understand the goal haha And yes using zipjs is compatible on both platforms Btw dont feel pressured to open a pr but if you are happy to ill give some guidance: - we already use zipjs in a few other places - when using zipjs with the lsps be careful to preserve symlinks and things - should be pretty easy to test the changes: clear the bin dir that lsps are installed in then: bun run dev debug lsp diagnostics <file> ^ should install lsp if not installed
yindo commented 2026-02-16 17:31:23 -05:00
Author
Owner
Copy Link
Copy Source

@vickywane commented on GitHub (Oct 12, 2025):

Haha

I'm happy to give it a shot!

Will read through the existing usages of zip.js

(Thanks for the suoerfast responses btw)

@vickywane commented on GitHub (Oct 12, 2025): Haha I'm happy to give it a shot! Will read through the existing usages of zip.js (Thanks for the suoerfast responses btw)
yindo commented 2026-02-16 17:31:23 -05:00
Author
Owner
Copy Link
Copy Source

@rekram1-node commented on GitHub (Oct 12, 2025):

ofc!

@rekram1-node commented on GitHub (Oct 12, 2025): ofc!
yindo commented 2026-02-16 17:31:23 -05:00
Author
Owner
Copy Link
Copy Source

@rekram1-node commented on GitHub (Oct 24, 2025):

@vickywane no rush are you still wanting to tackle this?

@rekram1-node commented on GitHub (Oct 24, 2025): @vickywane no rush are you still wanting to tackle this?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#1523
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?