anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 10:15:31 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

Empty SSE Events Leak Through Opencode Stream Processor #1869

New Issue
Closed
opened 2026-02-16 17:33:01 -05:00 by yindo · 2 comments
yindo commented 2026-02-16 17:33:01 -05:00
Owner
Copy Link
Copy Source

Originally created by @shantur on GitHub (Sep 28, 2025).

Originally assigned to: @rekram1-node on GitHub.

  • Summary: The shared SSE client in opencode/packages/sdk/js/src/gen/core/serverSentEvents.gen.ts emits an event for every data: stanza, even if the
    payload is empty/whitespace. Downstream code receives meaningless events, forcing consumers (e.g., the Gemini plugin) to filter them manually.
  • Impact: Plugins/tools that listen to streamed deltas must implement custom guards to avoid processing blank events. This leads to duplicated logic,
    brittle handling of real "" payloads, and wasted work for every SSE consumer.

This is visible when working with Gemini CLI OAauth

Propsed fix

opencode/packages/sdk/js/src/gen/core/serverSentEvents.gen.ts (+3 -0)
    155                    const rawData = dataLines.join("\n")
    156   +                if (!rawData.trim()) {
    157   +                  continue
    158   +                }
    159                    try {
Originally created by @shantur on GitHub (Sep 28, 2025). Originally assigned to: @rekram1-node on GitHub. - Summary: The shared SSE client in opencode/packages/sdk/js/src/gen/core/serverSentEvents.gen.ts emits an event for every data: stanza, even if the payload is empty/whitespace. Downstream code receives meaningless events, forcing consumers (e.g., the Gemini plugin) to filter them manually. - Impact: Plugins/tools that listen to streamed deltas must implement custom guards to avoid processing blank events. This leads to duplicated logic, brittle handling of real "" payloads, and wasted work for every SSE consumer. This is visible when working with Gemini CLI OAauth Propsed fix ``` opencode/packages/sdk/js/src/gen/core/serverSentEvents.gen.ts (+3 -0) 155 const rawData = dataLines.join("\n") 156 + if (!rawData.trim()) { 157 + continue 158 + } 159 try { ```
yindo closed this issue 2026-02-16 17:33:01 -05:00
yindo commented 2026-02-16 17:33:01 -05:00
Author
Owner
Copy Link
Copy Source

@rekram1-node commented on GitHub (Sep 28, 2025):

@shantur do u know which event types are being sent as blank strings?

@rekram1-node commented on GitHub (Sep 28, 2025): @shantur do u know which event types are being sent as blank strings?
yindo commented 2026-02-16 17:33:01 -05:00
Author
Owner
Copy Link
Copy Source

@shantur commented on GitHub (Sep 28, 2025):

@rekram1-node : heartbeat was one for sure

@shantur commented on GitHub (Sep 28, 2025): @rekram1-node : heartbeat was one for sure
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#1869
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?