anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 18:25:32 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

Code Quality: Type Safety and Test Coverage Improvements #3247

New Issue
Open
opened 2026-02-16 17:39:19 -05:00 by yindo · 2 comments
yindo commented 2026-02-16 17:39:19 -05:00
Owner
Copy Link
Copy Source

Originally created by @Developer1011x on GitHub (Dec 2, 2025).

Description

This issue tracks several code quality improvements identified during codebase analysis.

Issues Identified

1. Type Safety Issues (Medium Priority)

  • Multiple @ts-ignore and @ts-expect-error directives that can be fixed with proper typing
  • Use of any type in error handling that should be unknown
  • Provider loader typing that can use proper type assertions

2. Test Coverage Gaps (Medium Priority)

  • Permission boundary tests were skipped (patch.test.ts:51-64)
  • Directory traversal test was commented out (bash.test.ts:37-54)
  • Tests using unreliable setTimeout patterns instead of proper async polling

3. Code Quality Issues (Low-Medium)

  • Debug file util/scrap.ts with unused dummy functions in production code
  • Direct console.log calls in stats.ts bypassing the logging abstraction

4. Documentation

  • README could benefit from better structure, tables, and collapsible sections

Resolution

These issues have been addressed in PR #4971

Related Files

  • packages/opencode/src/index.ts
  • packages/opencode/src/session/processor.ts
  • packages/opencode/src/provider/provider.ts
  • packages/opencode/src/plugin/index.ts
  • packages/opencode/src/cli/cmd/stats.ts
  • packages/opencode/src/util/scrap.ts (removed)
  • packages/opencode/test/tool/patch.test.ts
  • packages/opencode/test/tool/bash.test.ts
  • README.md
Originally created by @Developer1011x on GitHub (Dec 2, 2025). ## Description This issue tracks several code quality improvements identified during codebase analysis. ## Issues Identified ### 1. Type Safety Issues (Medium Priority) - Multiple `@ts-ignore` and `@ts-expect-error` directives that can be fixed with proper typing - Use of `any` type in error handling that should be `unknown` - Provider loader typing that can use proper type assertions ### 2. Test Coverage Gaps (Medium Priority) - Permission boundary tests were skipped (`patch.test.ts:51-64`) - Directory traversal test was commented out (`bash.test.ts:37-54`) - Tests using unreliable `setTimeout` patterns instead of proper async polling ### 3. Code Quality Issues (Low-Medium) - Debug file `util/scrap.ts` with unused dummy functions in production code - Direct `console.log` calls in `stats.ts` bypassing the logging abstraction ### 4. Documentation - README could benefit from better structure, tables, and collapsible sections ## Resolution These issues have been addressed in PR #4971 ## Related Files - `packages/opencode/src/index.ts` - `packages/opencode/src/session/processor.ts` - `packages/opencode/src/provider/provider.ts` - `packages/opencode/src/plugin/index.ts` - `packages/opencode/src/cli/cmd/stats.ts` - `packages/opencode/src/util/scrap.ts` (removed) - `packages/opencode/test/tool/patch.test.ts` - `packages/opencode/test/tool/bash.test.ts` - `README.md`
yindo commented 2026-02-16 17:39:20 -05:00
Author
Owner
Copy Link
Copy Source

@github-actions[bot] commented on GitHub (Dec 2, 2025):

Analyzing for duplicates...

@github-actions[bot] commented on GitHub (Dec 2, 2025): Analyzing for duplicates...
yindo commented 2026-02-16 17:39:20 -05:00
Author
Owner
Copy Link
Copy Source

@github-actions[bot] commented on GitHub (Dec 2, 2025):

This issue might be a duplicate of existing issues. Please check:

  • #3667: TUI Test coverage to avoid regressions (related but specifically focused on TUI testing)

Feel free to ignore if none of these address your specific case.

@github-actions[bot] commented on GitHub (Dec 2, 2025): This issue might be a duplicate of existing issues. Please check: - #3667: TUI Test coverage to avoid regressions (related but specifically focused on TUI testing) Feel free to ignore if none of these address your specific case.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#3247
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?