anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

Memory leak: SDK event listeners never unsubscribed in App component #5387

New Issue
Open
opened 2026-02-16 17:52:05 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 17:52:05 -05:00
Owner
Copy Link
Copy Source

Originally created by @sauerdaniel on GitHub (Jan 13, 2026).

Originally assigned to: @rekram1-node on GitHub.

Problem

The TUI App component subscribes to 6 SDK events but never unsubscribes from them:

  • TuiEvent.CommandExecute
  • TuiEvent.ToastShow
  • TuiEvent.SessionSelect
  • SessionApi.Event.Deleted
  • SessionApi.Event.Error
  • Installation.Event.UpdateAvailable

The sdk.event.on() method returns an unsubscribe function that is being ignored.

Code Location

packages/opencode/src/cli/cmd/tui/app.tsx - lines 557-616

Impact

  • Event listeners accumulate over component lifecycle
  • Closures retain references preventing garbage collection
  • Memory growth in long-running sessions
  • Potential duplicate event handling

Relates to #5363

Expected Behavior

Event listeners should be stored and unsubscribed in onCleanup:

const unsubs: (() => void)[] = []

unsubs.push(sdk.event.on(TuiEvent.CommandExecute.type, (evt) => {
  command.trigger(evt.properties.command)
}))

// ... other listeners

onCleanup(() => {
  unsubs.forEach((unsub) => unsub())
})
Originally created by @sauerdaniel on GitHub (Jan 13, 2026). Originally assigned to: @rekram1-node on GitHub. ## Problem The TUI `App` component subscribes to 6 SDK events but never unsubscribes from them: - `TuiEvent.CommandExecute` - `TuiEvent.ToastShow` - `TuiEvent.SessionSelect` - `SessionApi.Event.Deleted` - `SessionApi.Event.Error` - `Installation.Event.UpdateAvailable` The `sdk.event.on()` method returns an unsubscribe function that is being ignored. ### Code Location `packages/opencode/src/cli/cmd/tui/app.tsx` - lines 557-616 ### Impact - Event listeners accumulate over component lifecycle - Closures retain references preventing garbage collection - Memory growth in long-running sessions - Potential duplicate event handling Relates to #5363 ## Expected Behavior Event listeners should be stored and unsubscribed in `onCleanup`: ```typescript const unsubs: (() => void)[] = [] unsubs.push(sdk.event.on(TuiEvent.CommandExecute.type, (evt) => { command.trigger(evt.properties.command) })) // ... other listeners onCleanup(() => { unsubs.forEach((unsub) => unsub()) }) ```
yindo added the perf label 2026-02-16 17:52:05 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label perf
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#5387
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?