anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

Memory leak: Footer component only clears last timeout in recursive chain #5401

New Issue
Closed
opened 2026-02-16 17:52:17 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 17:52:17 -05:00
Owner
Copy Link
Copy Source

Originally created by @sauerdaniel on GitHub (Jan 13, 2026).

Originally assigned to: @rekram1-node on GitHub.

Description

The Footer component uses a recursive setTimeout pattern for the welcome message animation, but only tracks the most recent timeout ID in a single variable.

function tick() {
  timeout = setTimeout(() => tick(), 5000)  // Overwrites previous ID
}
let timeout = setTimeout(() => tick(), 10_000)

onCleanup(() => {
  clearTimeout(timeout)  // Only clears the LAST timeout
})

When tick() schedules a new timeout, the previous timeout ID is lost before it can be cleared.

Impact

  • Earlier timeouts continue to fire after component unmount
  • Callbacks reference stale component state
  • Closures prevent garbage collection
  • Minor but cumulative memory leak

Location

packages/opencode/src/cli/cmd/tui/routes/session/footer.tsx - lines 27-47

Related

Part of #3013 (general memory issues)

Originally created by @sauerdaniel on GitHub (Jan 13, 2026). Originally assigned to: @rekram1-node on GitHub. ## Description The `Footer` component uses a recursive setTimeout pattern for the welcome message animation, but only tracks the most recent timeout ID in a single variable. ```typescript function tick() { timeout = setTimeout(() => tick(), 5000) // Overwrites previous ID } let timeout = setTimeout(() => tick(), 10_000) onCleanup(() => { clearTimeout(timeout) // Only clears the LAST timeout }) ``` When `tick()` schedules a new timeout, the previous timeout ID is lost before it can be cleared. ## Impact - Earlier timeouts continue to fire after component unmount - Callbacks reference stale component state - Closures prevent garbage collection - Minor but cumulative memory leak ## Location `packages/opencode/src/cli/cmd/tui/routes/session/footer.tsx` - lines 27-47 ## Related Part of #3013 (general memory issues)
yindo added the perf label 2026-02-16 17:52:17 -05:00
yindo closed this issue 2026-02-16 17:52:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label perf
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#5401
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?