anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 10:15:31 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

Use proper type for Config.McpLocal in MCP resolver #6844

New Issue
Closed
opened 2026-02-16 18:05:25 -05:00 by yindo · 1 comment
yindo commented 2026-02-16 18:05:25 -05:00
Owner
Copy Link
Copy Source

Originally created by @adolago on GitHub (Jan 19, 2026).

Originally assigned to: @thdxr on GitHub.

Problem

resolveLocalCommand uses Config.McpLocal as a type in packages/agent-core/src/mcp/index.ts, but it is a value (zod schema). This fails typecheck.

Proposed fix

  • Export a type alias for McpLocal in packages/agent-core/src/config/config.ts (e.g., export type McpLocal = z.infer<typeof McpLocal>), or
  • Define a local type alias via z.infer<typeof Config.McpLocal> in mcp/index.ts and use that in resolveLocalCommand.

Acceptance criteria

  • TS2749 is resolved.
  • resolveLocalCommand still accepts the same shape as the config schema.

Test plan

  • bun run typecheck
Originally created by @adolago on GitHub (Jan 19, 2026). Originally assigned to: @thdxr on GitHub. ## Problem `resolveLocalCommand` uses `Config.McpLocal` as a type in `packages/agent-core/src/mcp/index.ts`, but it is a value (zod schema). This fails typecheck. ## Proposed fix - Export a type alias for McpLocal in `packages/agent-core/src/config/config.ts` (e.g., `export type McpLocal = z.infer<typeof McpLocal>`), or - Define a local type alias via `z.infer<typeof Config.McpLocal>` in `mcp/index.ts` and use that in `resolveLocalCommand`. ## Acceptance criteria - TS2749 is resolved. - `resolveLocalCommand` still accepts the same shape as the config schema. ## Test plan - `bun run typecheck`
yindo closed this issue 2026-02-16 18:05:25 -05:00
yindo commented 2026-02-16 18:05:25 -05:00
Author
Owner
Copy Link
Copy Source

@github-actions[bot] commented on GitHub (Jan 19, 2026):

This issue might be a duplicate of existing issues. Please check:

  • #9481: Type mismatch in dialog-command test where keybind type is generic string instead of proper union
  • #9479: Similar pattern of type incompatibility with external SDK types in message parts
  • #9482: Optional parameter type mismatch in test vs production code
  • #9483: Implicit any type requiring explicit type annotations
  • #9480: TypeScript union type narrowing failure needing discriminant
  • #9477: Return type mismatch where string | undefined doesn't match specific union

All of these appear to be part of the same typecheck fix initiative targeting packages/agent-core/src/.

Feel free to ignore if this is addressing a unique aspect.

@github-actions[bot] commented on GitHub (Jan 19, 2026): This issue might be a duplicate of existing issues. Please check: - #9481: Type mismatch in dialog-command test where keybind type is generic string instead of proper union - #9479: Similar pattern of type incompatibility with external SDK types in message parts - #9482: Optional parameter type mismatch in test vs production code - #9483: Implicit any type requiring explicit type annotations - #9480: TypeScript union type narrowing failure needing discriminant - #9477: Return type mismatch where string | undefined doesn't match specific union All of these appear to be part of the same typecheck fix initiative targeting packages/agent-core/src/. Feel free to ignore if this is addressing a unique aspect.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#6844
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?