anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 10:15:31 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

Fix updatePart input narrowing for delta wrapper #6848

New Issue
Closed
opened 2026-02-16 18:05:25 -05:00 by yindo · 1 comment
yindo commented 2026-02-16 18:05:25 -05:00
Owner
Copy Link
Copy Source

Originally created by @adolago on GitHub (Jan 19, 2026).

Originally assigned to: @rekram1-node on GitHub.

Problem

Session.updatePart uses "delta" in input to select the part, but TypeScript cannot narrow the union and rejects part.messageID and part.id.

Proposed fix

  • Use "part" in input as the guard and set const part = "part" in input ? input.part : input.
  • If needed, introduce a discriminant (e.g., { kind: "delta", part: TextPart | ReasoningPart, delta?: string }) to make the union explicit.

Acceptance criteria

  • TS2339/TS2322 errors around part.messageID and part.id are resolved.
  • MessageV2.Event.PartUpdated still emits part and optional delta.

Test plan

  • bun run typecheck
Originally created by @adolago on GitHub (Jan 19, 2026). Originally assigned to: @rekram1-node on GitHub. ## Problem `Session.updatePart` uses `"delta" in input` to select the part, but TypeScript cannot narrow the union and rejects `part.messageID` and `part.id`. ## Proposed fix - Use `"part" in input` as the guard and set `const part = "part" in input ? input.part : input`. - If needed, introduce a discriminant (e.g., `{ kind: "delta", part: TextPart | ReasoningPart, delta?: string }`) to make the union explicit. ## Acceptance criteria - TS2339/TS2322 errors around `part.messageID` and `part.id` are resolved. - `MessageV2.Event.PartUpdated` still emits `part` and optional `delta`. ## Test plan - `bun run typecheck`
yindo closed this issue 2026-02-16 18:05:25 -05:00
yindo commented 2026-02-16 18:05:26 -05:00
Author
Owner
Copy Link
Copy Source

@adolago commented on GitHub (Jan 19, 2026):

Opened in the wrong repo; will recreate on the fork.

@adolago commented on GitHub (Jan 19, 2026): Opened in the wrong repo; will recreate on the fork.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#6848
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?