anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

refactor: centralize tool plugin hooks + add agent to hook input #9283

New Issue
Open
opened 2026-02-16 18:12:05 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:12:05 -05:00
Owner
Copy Link
Copy Source

Originally created by @ArmirKS on GitHub (Feb 13, 2026).

Originally assigned to: @thdxr on GitHub.

Description

prompt.ts has the same before/after plugin hook logic inline in 3 separate places, and none of them pass agent to the hooks. This means plugins can't tell which agent made a tool call — a blocker for any plugin that needs per-agent policy (audit logging, permission enforcement, etc).

Steps to reproduce

  1. Create a plugin that hooks tool.execute.before and logs the input
  2. Trigger tool calls from different agents (primary + subagents via task)
  3. Observe that the hook input has no agent field — the plugin can't distinguish who made the call

Fix

PR #13521 adds Tool.invoke() that centralizes hook wrapping and adds agent to the hook input.

The original batch bypass issue is moot since batch is experimental and being deprecated.

Originally created by @ArmirKS on GitHub (Feb 13, 2026). Originally assigned to: @thdxr on GitHub. ### Description `prompt.ts` has the same before/after plugin hook logic inline in 3 separate places, and none of them pass `agent` to the hooks. This means plugins can't tell which agent made a tool call — a blocker for any plugin that needs per-agent policy (audit logging, permission enforcement, etc). ### Steps to reproduce 1. Create a plugin that hooks `tool.execute.before` and logs the input 2. Trigger tool calls from different agents (primary + subagents via task) 3. Observe that the hook input has no `agent` field — the plugin can't distinguish who made the call ### Fix PR #13521 adds `Tool.invoke()` that centralizes hook wrapping and adds `agent` to the hook input. --- ~~The original batch bypass issue is moot since batch is experimental and being deprecated.~~
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#9283
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?