anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-21 17:56:33 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

GET /session: Add ORDER BY time_updated DESC to Session.list() for deterministic ordering and correct limit behavior #9313

New Issue
Closed
opened 2026-02-16 18:12:09 -05:00 by yindo · 2 comments
yindo commented 2026-02-16 18:12:09 -05:00
Owner
Copy Link
Copy Source

Originally created by @zhoujinliang on GitHub (Feb 14, 2026).

Originally assigned to: @thdxr on GitHub.

Description

GET /session: Add ORDER BY time_updated DESC to Session.list() for deterministic ordering and correct limit behavior

Problem

The Session.list() function in packages/opencode/src/session/index.ts does not include an ORDER BY clause:

export function* list() {
    const rows = Database.use((db) =>
      db
        .select()
        .from(SessionTable)
        .where(eq(SessionTable.project_id, project.id))
        .all(),  // No ORDER BY
    )
    // ...
}

This causes two issues:

  1. Undefined ordering — The GET /session endpoint returns sessions in SQLite's internal storage order, which is not guaranteed to be stable or meaningful.

  2. limit truncates arbitrarily — When limit is used, clients receive an arbitrary subset of sessions rather than the most recently active ones. This makes the limit parameter unreliable for any practical use case (pagination, initial load, etc.).

Expected Behavior

Sessions should be returned in time_updated DESC order (most recently active first). This is consistent with:

  • How the TUI already handles this (client-side .toSorted((a, b) => b.time.updated - a.time.updated))
  • Standard UX expectations (chat apps, IDEs, etc.)
  • Making limit useful — "give me the N most recent sessions"

Suggested Fix

Add ORDER BY at the database level in Session.list():

import { desc } from "../storage/db"

export function* list() {
    const project = Instance.project
    const rows = Database.use((db) =>
      db
        .select()
        .from(SessionTable)
        .where(eq(SessionTable.project_id, project.id))
        .orderBy(desc(SessionTable.time_updated))  // ← Add this
        .all(),
    )
    for (const row of rows) {
      yield fromRow(row)
    }
}

Bonus: offset support

For clients that need pagination (e.g., GUI apps showing session lists), adding an offset query parameter to GET /session would be very helpful:

// In route handler, after sorting at DB level:
if (query.offset !== undefined) {
    sessions = sessions.slice(query.offset)
}

Context

I'm building a GUI client for OpenCode. Currently I have to fetch all sessions and sort client-side because:

  1. The API order is undefined
  2. limit without ordering gives arbitrary results
  3. There's no offset for pagination

Server-side ORDER BY + offset would significantly reduce client complexity and data transfer.

Plugins

No response

OpenCode version

1.1.55

Steps to reproduce

No response

Screenshot and/or share link

No response

Operating System

macos 26

Terminal

Ghostty

Originally created by @zhoujinliang on GitHub (Feb 14, 2026). Originally assigned to: @thdxr on GitHub. ### Description # `GET /session`: Add `ORDER BY time_updated DESC` to `Session.list()` for deterministic ordering and correct `limit` behavior ## Problem The `Session.list()` function in `packages/opencode/src/session/index.ts` does not include an `ORDER BY` clause: ```typescript export function* list() { const rows = Database.use((db) => db .select() .from(SessionTable) .where(eq(SessionTable.project_id, project.id)) .all(), // No ORDER BY ) // ... } ``` This causes two issues: 1. **Undefined ordering** — The `GET /session` endpoint returns sessions in SQLite's internal storage order, which is not guaranteed to be stable or meaningful. 2. **`limit` truncates arbitrarily** — When `limit` is used, clients receive an arbitrary subset of sessions rather than the most recently active ones. This makes the `limit` parameter unreliable for any practical use case (pagination, initial load, etc.). ## Expected Behavior Sessions should be returned in **`time_updated DESC`** order (most recently active first). This is consistent with: - How the TUI already handles this (client-side `.toSorted((a, b) => b.time.updated - a.time.updated)`) - Standard UX expectations (chat apps, IDEs, etc.) - Making `limit` useful — "give me the N most recent sessions" ## Suggested Fix Add `ORDER BY` at the database level in `Session.list()`: ```typescript import { desc } from "../storage/db" export function* list() { const project = Instance.project const rows = Database.use((db) => db .select() .from(SessionTable) .where(eq(SessionTable.project_id, project.id)) .orderBy(desc(SessionTable.time_updated)) // ← Add this .all(), ) for (const row of rows) { yield fromRow(row) } } ``` ## Bonus: `offset` support For clients that need pagination (e.g., GUI apps showing session lists), adding an `offset` query parameter to `GET /session` would be very helpful: ```typescript // In route handler, after sorting at DB level: if (query.offset !== undefined) { sessions = sessions.slice(query.offset) } ``` ## Context I'm building a GUI client for OpenCode. Currently I have to fetch **all** sessions and sort client-side because: 1. The API order is undefined 2. `limit` without ordering gives arbitrary results 3. There's no `offset` for pagination Server-side `ORDER BY` + `offset` would significantly reduce client complexity and data transfer. ### Plugins _No response_ ### OpenCode version 1.1.55 ### Steps to reproduce _No response_ ### Screenshot and/or share link _No response_ ### Operating System macos 26 ### Terminal Ghostty
yindo added the bug label 2026-02-16 18:12:09 -05:00
yindo closed this issue 2026-02-16 18:12:09 -05:00
yindo commented 2026-02-16 18:12:09 -05:00
Author
Owner
Copy Link
Copy Source

@github-actions[bot] commented on GitHub (Feb 14, 2026):

This issue might be related to existing issues. Please check:

  • #4918: feature request: pagination for messages & sessions (broader pagination request that includes sessions)

The current issue is specifically focused on database-level ordering and limit behavior, which is a more targeted improvement that would complement broader pagination support.

@github-actions[bot] commented on GitHub (Feb 14, 2026): This issue might be related to existing issues. Please check: - #4918: feature request: pagination for messages & sessions (broader pagination request that includes sessions) The current issue is specifically focused on database-level ordering and `limit` behavior, which is a more targeted improvement that would complement broader pagination support.
yindo commented 2026-02-16 18:12:09 -05:00
Author
Owner
Copy Link
Copy Source

@thdxr commented on GitHub (Feb 14, 2026):

good call - fixed in latest

@thdxr commented on GitHub (Feb 14, 2026): good call - fixed in latest
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#9313
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?