anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #1123] [CLOSED] test: Defines symbols for successful test build #9819

New Issue
Closed
opened 2026-02-16 18:14:13 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:14:13 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opencode/pull/1123
Author: @theoboldalex
Created: 7/18/2025
Status: ❌ Closed

Base: dev ← Head: dev

📝 Commits (2)

  • e54bb6f test: Defines symbols for successful test build
  • 79f4320 chore: removes unused definition

📊 Changes

1 file changed (+16 additions, -0 deletions)

View changed files

📝 packages/tui/internal/components/list/list.go (+16 -0)

📄 Description

There were two symbols used in list_test.go that were not defined. This pull request defines them.

While this does make the tests compile and pass, I am not sure if the correct behaviour is actually being verified. I have not contributed to this project before (only been a user for a week or two) so I don't have a good handle on the codebase as a whole yet. It doesn't seem like these tests are being run in CI? Is that intentional?

I would appreciate some feedback and guidance on whether this is a valuable change or alternative approaches.

Thanks

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opencode/pull/1123 **Author:** [@theoboldalex](https://github.com/theoboldalex) **Created:** 7/18/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (2) - [`e54bb6f`](https://github.com/anomalyco/opencode/commit/e54bb6f79052fac4d632535fdf7d84f39095510b) test: Defines symbols for successful test build - [`79f4320`](https://github.com/anomalyco/opencode/commit/79f43206c7a327a0fdaec0cca18a28d2aa4aabd7) chore: removes unused definition ### 📊 Changes **1 file changed** (+16 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/tui/internal/components/list/list.go` (+16 -0) </details> ### 📄 Description There were two symbols used in `list_test.go` that were not defined. This pull request defines them. While this does make the tests compile and pass, I am not sure if the correct behaviour is actually being verified. I have not contributed to this project before (only been a user for a week or two) so I don't have a good handle on the codebase as a whole yet. It doesn't seem like these tests are being run in CI? Is that intentional? I would appreciate some feedback and guidance on whether this is a valuable change or alternative approaches. Thanks --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 18:14:13 -05:00
yindo closed this issue 2026-02-16 18:14:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#9819
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?