anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 18:25:32 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #1138] [MERGED] fix table heading rendering #9826

New Issue
Closed
opened 2026-02-16 18:14:14 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:14:14 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opencode/pull/1138
Author: @CodinCat
Created: 7/18/2025
Status: ✅ Merged
Merged: 7/18/2025
Merged by: @adamdotdevin

Base: dev ← Head: fix-table-heading-rendering

📝 Commits (2)

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 packages/tui/internal/styles/markdown.go (+0 -1)

📄 Description

fix #688

These \n have existed since the first commit. I'm not sure what's the purpose of it, but they are breaking the table rendering. The entire table looks quite weird and the headings are missing.

The background color of the table also doesn't look right, but it seems to be an issue of glamour. They've already fixed it but just haven't released it yet.

Before

before

After

after

a small issue is that the color of ColumnSeparator is different from CenterSeparator and RowSeparator (these two seem to be TextMuted). not sure where they inherit the colors from. at least the table looks more normal now

Update:

just found that if we keep the BlockSuffix the border colors will look consistent. I've updated the code. it adds some extra spaces but I assume it looks better?

BlockSuffix

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opencode/pull/1138 **Author:** [@CodinCat](https://github.com/CodinCat) **Created:** 7/18/2025 **Status:** ✅ Merged **Merged:** 7/18/2025 **Merged by:** [@adamdotdevin](https://github.com/adamdotdevin) **Base:** `dev` ← **Head:** `fix-table-heading-rendering` --- ### 📝 Commits (2) - [`17da620`](https://github.com/anomalyco/opencode/commit/17da620d50e2dc2689d4e747ee79c655767fd169) fix table heading rendering - [`d7ad0df`](https://github.com/anomalyco/opencode/commit/d7ad0dff6fce6d180ecf6f15dbfa7d88b95ee226) keep BlockSuffix ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/tui/internal/styles/markdown.go` (+0 -1) </details> ### 📄 Description fix #688 These `\n` have existed since the first commit. I'm not sure what's the purpose of it, but they are breaking the table rendering. The entire table looks quite weird and the headings are missing. The background color of the table also doesn't look right, but it seems to be an issue of glamour. They've already fixed it but just haven't released it yet. ### Before <img width="1142" height="296" alt="before" src="https://github.com/user-attachments/assets/7435bfeb-b8ea-40da-af9a-765bda3dfc0c" /> ### After <img width="1143" height="174" alt="after" src="https://github.com/user-attachments/assets/8ee65eae-a1d5-41c2-991c-f52ee5155b5f" /> a small issue is that the color of `ColumnSeparator` is different from `CenterSeparator` and `RowSeparator` (these two seem to be `TextMuted`). not sure where they inherit the colors from. at least the table looks more normal now --- Update: just found that if we keep the `BlockSuffix` the border colors will look consistent. I've updated the code. it adds some extra spaces but I assume it looks better? <img width="1146" height="227" alt="BlockSuffix" src="https://github.com/user-attachments/assets/85060585-c729-4dfe-b912-84806baab3af" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 18:14:14 -05:00
yindo closed this issue 2026-02-16 18:14:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#9826
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?