[skia] add new port (#10083)

* [skia] add new port * [skia] add support for x64-windows * [skia] use vswhere to locate MSVC * [skia] update supports CONTROL field * [skia] address review comments * [skia] add compile definitions for metal * [skia] use vcpkg to find programfiles * [skia] add glob_single_file function
2024-11-27 21:20:21 +00:00 · 2020-03-04 13:06:24 -08:00 · 2020-03-04 13:06:24 -08:00 · e368f0f4ce
commit e368f0f4ce
parent 350f647fd6
4 changed files with 319 additions and 0 deletions
--- a/ports/skia/CONTROL
+++ b/ports/skia/CONTROL
@ -0,0 +1,10 @@
+Source: skia
+Version: 2020-02-15
+Homepage: https://skia.org
+Description: Skia is an open source 2D graphics library which provides common APIs that work across a variety of hardware and software platforms.
+  It serves as the graphics engine for Google Chrome and Chrome OS, Android, Mozilla Firefox and Firefox OS, and many other products.
+  Skia is sponsored and managed by Google, but is available for use by anyone under the BSD Free Software License. While engineering of the core components is done by the Skia development team, we consider contributions from any source.
+Supports: x64 & (osx | windows)
+
+Feature: metal
+Description: metal support for skia
--- a/ports/skia/portfile.cmake
+++ b/ports/skia/portfile.cmake
@ -0,0 +1,226 @@
+vcpkg_fail_port_install(
+    ON_ARCH "x86" "arm" "arm64"
+    ON_TARGET "UWP" "LINUX" "ANDROID" "FREEBSD")
+
+vcpkg_from_git(
+    OUT_SOURCE_PATH SOURCE_PATH
+    URL https://skia.googlesource.com/skia.git
+    REF 05676f7bc238f667de848dfd37b4aa3c01b69efb
+)
+
+find_program(GIT NAMES git git.cmd)
+set(ENV{GIT_EXECUTABLE} "${GIT}")
+
+vcpkg_find_acquire_program(PYTHON2)
+get_filename_component(PYTHON2_DIR "${PYTHON2}" DIRECTORY)
+vcpkg_add_to_path(PREPEND "${PYTHON2_DIR}")
+
+vcpkg_find_acquire_program(NINJA)
+
+message(STATUS "Syncing git dependencies...")
+vcpkg_execute_required_process(
+    COMMAND "${PYTHON2}" tools/git-sync-deps
+    WORKING_DIRECTORY "${SOURCE_PATH}"
+    LOGNAME sync-deps-${TARGET_TRIPLET}
+)
+
+find_program(GN gn PATHS "${SOURCE_PATH}/bin" "${DEPOT_TOOLS_PATH}")
+
+set(OPTIONS "\
+skia_use_system_libjpeg_turbo=false \
+skia_use_system_libpng=false \
+skia_use_system_libwebp=false \
+skia_use_system_icu=false \
+skia_use_system_expat=false \
+skia_use_system_zlib=false")
+
+# used for passing feature-specific definitions to the config file
+set(SKIA_PUBLIC_DEFINITIONS "")
+
+if(VCPKG_LIBRARY_LINKAGE STREQUAL dynamic)
+    set(OPTIONS "${OPTIONS} is_component_build=true")
+else()
+    set(OPTIONS "${OPTIONS} is_component_build=false")
+endif()
+
+if("metal" IN_LIST FEATURES)
+    set(OPTIONS "${OPTIONS} skia_use_metal=true")
+    list(APPEND SKIA_PUBLIC_DEFINITIONS SK_METAL)
+endif()
+
+set(OPTIONS_REL "${OPTIONS} is_official_build=true")
+set(OPTIONS_DBG "${OPTIONS} is_debug=true")
+
+function(find_msvc_path PATH)
+    vcpkg_get_program_files_32_bit(PROGRAM_FILES)
+    file(TO_CMAKE_PATH "${PROGRAM_FILES}" PROGRAM_FILES)
+    set(VSWHERE "${PROGRAM_FILES}/Microsoft Visual Studio/Installer/vswhere.exe")
+    execute_process(
+        COMMAND "${VSWHERE}" -prerelease -legacy -products * -sort -utf8 -property installationPath
+        WORKING_DIRECTORY "${SOURCE_PATH}"
+        OUTPUT_VARIABLE OUTPUT_
+        OUTPUT_STRIP_TRAILING_WHITESPACE
+    )
+    string(REGEX REPLACE "\n|(\r\n)" ";" OUTPUT_ "${OUTPUT_}")
+    list(GET OUTPUT_ 0 OUTPUT_)
+    
+    set(${PATH} "${OUTPUT_}" PARENT_SCOPE)
+endfunction()
+
+if(CMAKE_HOST_WIN32)
+    # Load toolchains
+    if(NOT VCPKG_CHAINLOAD_TOOLCHAIN_FILE)
+        set(VCPKG_CHAINLOAD_TOOLCHAIN_FILE "${SCRIPTS}/toolchains/windows.cmake")
+    endif()
+    include("${VCPKG_CHAINLOAD_TOOLCHAIN_FILE}")
+
+    # turn a space delimited string into a gn list:
+    # "a b c" -> ["a","b","c"]
+    function(to_gn_list OUTPUT_ INPUT_)
+        string(STRIP "${INPUT_}" TEMP)
+        string(REPLACE "  " " " TEMP "${TEMP}")
+        string(REPLACE " " "\",\"" TEMP "${TEMP}")
+        set(${OUTPUT_} "[\"${TEMP}\"]" PARENT_SCOPE)
+    endfunction()
+
+    to_gn_list(SKIA_C_FLAGS_DBG "${CMAKE_C_FLAGS} ${CMAKE_C_FLAGS_DEBUG}")
+    to_gn_list(SKIA_C_FLAGS_REL "${CMAKE_C_FLAGS} ${CMAKE_C_FLAGS_RELEASE}")
+
+    to_gn_list(SKIA_CXX_FLAGS_DBG "${CMAKE_CXX_FLAGS} ${CMAKE_CXX_FLAGS_DEBUG}")
+    to_gn_list(SKIA_CXX_FLAGS_REL "${CMAKE_CXX_FLAGS} ${CMAKE_CXX_FLAGS_RELEASE}")
+
+    set(OPTIONS_DBG "${OPTIONS_DBG} extra_cflags_c=${SKIA_C_FLAGS_DBG} \
+        extra_cflags_cc=${SKIA_CXX_FLAGS_DBG}")
+
+    set(OPTIONS_REL "${OPTIONS_REL} extra_cflags_c=${SKIA_C_FLAGS_REL} \
+        extra_cflags_cc=${SKIA_CXX_FLAGS_REL}")
+
+    find_msvc_path(WIN_VC)
+    set(WIN_VC "${WIN_VC}\\VC")
+    set(OPTIONS_DBG "${OPTIONS_DBG} win_vc=\"${WIN_VC}\"")
+    set(OPTIONS_REL "${OPTIONS_REL} win_vc=\"${WIN_VC}\"")
+
+endif()
+
+set(BUILD_DIR_REL "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel")
+set(BUILD_DIR_DBG "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-dbg")
+
+message(STATUS "Generating build (debug)...")
+vcpkg_execute_required_process(
+    COMMAND "${GN}" gen "${BUILD_DIR_DBG}" --args=${OPTIONS_DBG}
+    WORKING_DIRECTORY "${SOURCE_PATH}"
+    LOGNAME generate-${TARGET_TRIPLET}-dbg
+)
+
+message(STATUS "Generating build (release)...")
+vcpkg_execute_required_process(
+    COMMAND "${GN}" gen "${BUILD_DIR_REL}" --args=${OPTIONS_REL}
+    WORKING_DIRECTORY "${SOURCE_PATH}"
+    LOGNAME generate-${TARGET_TRIPLET}-rel
+)
+
+message(STATUS "Building Skia (debug)...")
+vcpkg_execute_build_process(
+    COMMAND "${NINJA}" -C "${BUILD_DIR_DBG}" skia
+    WORKING_DIRECTORY "${SOURCE_PATH}"
+    LOGNAME build-${TARGET_TRIPLET}-dbg
+)
+
+message(STATUS "Building Skia (release)...")
+vcpkg_execute_build_process(
+    COMMAND "${NINJA}" -C "${BUILD_DIR_REL}" skia
+    WORKING_DIRECTORY "${SOURCE_PATH}"
+    LOGNAME build-${TARGET_TRIPLET}-rel
+)
+
+message(STATUS "Installing: ${CURRENT_PACKAGES_DIR}/include/${PORT}")
+file(COPY "${SOURCE_PATH}/include" 
+    DESTINATION "${CURRENT_PACKAGES_DIR}/include")
+file(RENAME "${CURRENT_PACKAGES_DIR}/include/include" 
+    "${CURRENT_PACKAGES_DIR}/include/${PORT}")
+file(GLOB_RECURSE SKIA_INCLUDE_FILES LIST_DIRECTORIES false 
+    "${CURRENT_PACKAGES_DIR}/include/${PORT}/*")
+foreach(file_ ${SKIA_INCLUDE_FILES})
+    vcpkg_replace_string("${file_}" "#include \"include/" "#include \"${PORT}/")
+endforeach()
+
+# Finds and stores a single file that matches GLOBBING_EXPR
+# into the OUT_VAR or fails otherwise
+function(glob_single_file OUT_VAR GLOBBING_EXPR)
+    file(GLOB RESULTS LIST_DIRECTORIES false "${GLOBBING_EXPR}")
+    list(LENGTH RESULTS RESULTS_LENGTH)
+    if(NOT RESULTS_LENGTH EQUAL 1)
+        message(FATAL_ERROR "Expected one file to match glob: '${GLOBBING_EXPR}'; found: '${RESULTS}'")
+    endif()
+    list(GET RESULTS 0 FIRST_RESULT)
+    set(${OUT_VAR} "${FIRST_RESULT}" PARENT_SCOPE)
+endfunction()
+
+if(VCPKG_TARGET_IS_WINDOWS)
+    glob_single_file(SKIA_LIBRARY_DBG "${BUILD_DIR_DBG}/skia*.lib")
+    file(INSTALL "${SKIA_LIBRARY_DBG}" 
+        DESTINATION "${CURRENT_PACKAGES_DIR}/debug/lib")
+
+    glob_single_file(SKIA_LIBRARY_REL "${BUILD_DIR_REL}/skia*.lib")
+    file(INSTALL "${SKIA_LIBRARY_REL}" 
+        DESTINATION "${CURRENT_PACKAGES_DIR}/lib")
+
+    if(VCPKG_LIBRARY_LINKAGE STREQUAL dynamic)
+        get_filename_component(SKIA_LIBRARY_IMPLIB_DBG 
+            "${SKIA_LIBRARY_DBG}" NAME)
+        get_filename_component(SKIA_LIBRARY_IMPLIB_REL 
+            "${SKIA_LIBRARY_REL}" NAME)
+
+        glob_single_file(SKIA_LIBRARY_DBG "${BUILD_DIR_DBG}/skia*.dll")
+        file(INSTALL "${SKIA_LIBRARY_DBG}" 
+            DESTINATION "${CURRENT_PACKAGES_DIR}/debug/bin")
+        get_filename_component(SKIA_LIBRARY_NAME_DBG "${SKIA_LIBRARY_DBG}" NAME)
+
+        glob_single_file(SKIA_LIBRARY_DBG "${BUILD_DIR_DBG}/skia*.pdb")
+        file(INSTALL "${SKIA_LIBRARY_DBG}" 
+            DESTINATION "${CURRENT_PACKAGES_DIR}/debug/bin")
+
+        glob_single_file(SKIA_LIBRARY_REL "${BUILD_DIR_REL}/skia*.dll")
+        file(INSTALL "${SKIA_LIBRARY_REL}" 
+            DESTINATION "${CURRENT_PACKAGES_DIR}/bin")
+        get_filename_component(SKIA_LIBRARY_NAME_REL "${SKIA_LIBRARY_REL}" NAME)
+    else()
+        get_filename_component(SKIA_LIBRARY_NAME_DBG "${SKIA_LIBRARY_DBG}" NAME)
+        get_filename_component(SKIA_LIBRARY_NAME_REL "${SKIA_LIBRARY_REL}" NAME)
+    endif()
+else()
+    find_library(SKIA_LIBRARY_DBG skia PATHS "${BUILD_DIR_DBG}" NO_DEFAULT_PATH)
+    file(INSTALL "${SKIA_LIBRARY_DBG}" 
+        DESTINATION "${CURRENT_PACKAGES_DIR}/debug/lib")
+
+    find_library(SKIA_LIBRARY_REL skia PATHS "${BUILD_DIR_REL}" NO_DEFAULT_PATH)
+    file(INSTALL "${SKIA_LIBRARY_REL}" 
+        DESTINATION "${CURRENT_PACKAGES_DIR}/lib")
+
+    get_filename_component(SKIA_LIBRARY_NAME_DBG "${SKIA_LIBRARY_DBG}" NAME)
+    get_filename_component(SKIA_LIBRARY_NAME_REL "${SKIA_LIBRARY_REL}" NAME)
+endif()
+
+# get a list of library dependencies for TARGET
+function(gn_desc_target_libs SOURCE_PATH BUILD_DIR TARGET OUTPUT)
+    execute_process(
+        COMMAND ${GN} desc "${BUILD_DIR}" "${TARGET}" libs
+        WORKING_DIRECTORY "${SOURCE_PATH}"
+        OUTPUT_VARIABLE OUTPUT_
+        OUTPUT_STRIP_TRAILING_WHITESPACE
+    )
+    string(REGEX REPLACE "\n|(\r\n)" ";" OUTPUT_ "${OUTPUT_}")
+    set(${OUTPUT} ${OUTPUT_} PARENT_SCOPE)
+endfunction()
+
+# skiaConfig.cmake.in input variables
+gn_desc_target_libs("${SOURCE_PATH}" "${BUILD_DIR_DBG}" //:skia SKIA_DEP_DBG)
+gn_desc_target_libs("${SOURCE_PATH}" "${BUILD_DIR_REL}" //:skia SKIA_DEP_REL)
+
+configure_file("${CMAKE_CURRENT_LIST_DIR}/skiaConfig.cmake.in"
+        "${CURRENT_PACKAGES_DIR}/share/skia/skiaConfig.cmake" @ONLY)
+
+vcpkg_copy_pdbs()
+file(INSTALL "${SOURCE_PATH}/LICENSE"
+    DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}"
+    RENAME copyright)
--- a/ports/skia/skiaConfig.cmake.in
+++ b/ports/skia/skiaConfig.cmake.in
@ -0,0 +1,78 @@
+add_library(skia::skia SHARED IMPORTED)
+set(SKIA_DEP_DBG @SKIA_DEP_DBG@)
+set(SKIA_DEP_REL @SKIA_DEP_REL@)
+
+set(SKIA_LIBRARY_NAME_DBG @SKIA_LIBRARY_NAME_DBG@)
+set(SKIA_LIBRARY_NAME_REL @SKIA_LIBRARY_NAME_REL@)
+set(SKIA_LIBRARY_IMPLIB_DBG @SKIA_LIBRARY_IMPLIB_DBG@)
+set(SKIA_LIBRARY_IMPLIB_REL @SKIA_LIBRARY_IMPLIB_REL@)
+
+set(SKIA_PUBLIC_DEFINITIONS @SKIA_PUBLIC_DEFINITIONS@)
+
+# Compute the installation prefix relative to this file.
+get_filename_component(_IMPORT_PREFIX "${CMAKE_CURRENT_LIST_FILE}" PATH)
+get_filename_component(_IMPORT_PREFIX "${_IMPORT_PREFIX}" PATH)
+get_filename_component(_IMPORT_PREFIX "${_IMPORT_PREFIX}" PATH)
+if(_IMPORT_PREFIX STREQUAL "/")
+  set(_IMPORT_PREFIX "")
+endif()
+
+if(WIN32)
+    if(SKIA_LIBRARY_IMPLIB_DBG)
+        set_property(TARGET skia::skia PROPERTY
+            IMPORTED_IMPLIB_DEBUG "${_IMPORT_PREFIX}/debug/lib/${SKIA_LIBRARY_IMPLIB_DBG}"
+        )
+        set_property(TARGET skia::skia PROPERTY
+            IMPORTED_LOCATION_DEBUG "${_IMPORT_PREFIX}/debug/bin/${SKIA_LIBRARY_NAME_DBG}"
+        )
+    else()
+        set_property(TARGET skia::skia PROPERTY
+            IMPORTED_IMPLIB_DEBUG "${_IMPORT_PREFIX}/debug/lib/${SKIA_LIBRARY_NAME_DBG}"
+        )
+    endif()
+
+    if(SKIA_LIBRARY_IMPLIB_REL)
+        set_property(TARGET skia::skia PROPERTY
+            IMPORTED_IMPLIB_RELEASE "${_IMPORT_PREFIX}/lib/${SKIA_LIBRARY_IMPLIB_REL}"
+        )
+        set_property(TARGET skia::skia PROPERTY
+            IMPORTED_LOCATION_RELEASE "${_IMPORT_PREFIX}/bin/${SKIA_LIBRARY_NAME_REL}"
+        )
+    else()
+        set_property(TARGET skia::skia PROPERTY
+            IMPORTED_IMPLIB_RELEASE "${_IMPORT_PREFIX}/lib/${SKIA_LIBRARY_NAME_REL}"
+        )
+    endif()
+else()
+    set_property(TARGET skia::skia PROPERTY
+        IMPORTED_LOCATION_DEBUG "${_IMPORT_PREFIX}/debug/lib/${SKIA_LIBRARY_NAME_DBG}"
+    )
+    set_property(TARGET skia::skia PROPERTY
+        IMPORTED_LOCATION_RELEASE "${_IMPORT_PREFIX}/lib/${SKIA_LIBRARY_NAME_REL}"
+    )
+endif()
+
+foreach(LIB ${SKIA_DEP_DBG})
+    string(REGEX REPLACE "\\.framework" "" LIB ${LIB})
+    string(REGEX REPLACE "[^a-zA-Z]" "_" LIB_NAME ${LIB})
+    string(TOUPPER ${LIB_NAME} LIB_NAME)
+    set(LIB_NAME SKIA_${LIB_NAME}_LIBRARY)
+    find_library(${LIB_NAME} ${LIB})
+    set_property(TARGET skia::skia
+            APPEND PROPERTY INTERFACE_LINK_LIBRARIES
+            "$<$<CONFIG:Debug>:${${LIB_NAME}}>")
+endforeach()
+
+foreach(LIB ${SKIA_DEP_REL})
+    string(REGEX REPLACE "\\.framework" "" LIB ${LIB})
+    string(REGEX REPLACE "[^a-zA-Z]" "_" LIB_NAME ${LIB})
+    string(TOUPPER ${LIB_NAME} LIB_NAME)
+    set(LIB_NAME SKIA_${LIB_NAME}_LIBRARY)
+    find_library(${LIB_NAME} ${LIB})
+    set_property(TARGET skia::skia
+            APPEND PROPERTY INTERFACE_LINK_LIBRARIES
+            "$<$<CONFIG:Release>:${${LIB_NAME}}>")
+endforeach()
+
+target_include_directories(skia::skia INTERFACE ${_IMPORT_PREFIX}/include)
+target_compile_definitions(skia::skia INTERFACE ${SKIA_PUBLIC_DEFINITIONS})
--- a/scripts/ci.baseline.txt
+++ b/scripts/ci.baseline.txt
@ -1604,6 +1604,11 @@ shogun:x86-windows        = skip
 simdjson:arm64-windows=fail
 simdjson:arm-uwp=fail
 simdjson:x86-windows=fail
+skia:arm64-windows=fail
+skia:arm-uwp=fail
+skia:x64-linux=fail
+skia:x64-uwp=fail
+skia:x86-windows=fail
 slikenet:arm-uwp=fail
 slikenet:x64-uwp=fail
 smpeg2:arm-uwp=fail