mirror of
https://github.com/codewhale-hq/Codewhale.git
synced 2026-11-08 08:04:25 -10:00
fix(ci): shorten the cloud-dispatch feature summary and retire the stale installer assertion [skip ci]
Two of the hosted-red checks seen on main (run 40208377293, PR #7087 at basef98cb165a3) are repo-side drift, not the PR's: - docs/features.toml: the cloud-computer-dispatch summary was 143 characters; the feature_registry test allows 1-120 on one line. Reworded to fit. - .github/scripts/release-workflows.test.js:e9c9de775fdeliberately dropped the codewhale-tui compatibility-path guard from scripts/release/install.sh (the installer never writes that name), but this script still demanded a legacy_tui validation, so the "Version drift" job failed with "archive installs must validate the retired TUI path". The stale match and its now-false comment are removed, and the companion doesNotMatch (which tested a variable that no longer exists, so it could never fail) now asserts the installer never installs a file to $BIN_DIR/codewhale-tui. Still red and NOT fixed here: Lint fails on clippy::should_implement_trait for FleetRole::from_str at crates/agent-contract/src/role.rs:148 (about 15 call sites in crates/tui). That edit recompiles codewhale-tui and belongs to the Engine owner's next batch. Verified (own runs on the current tree): node .github/scripts/release-workflows.test.js: exit 0 (was: AssertionError at the legacy_tui assertion on the same tree before the edit). python tomllib over docs/features.toml: 79 rows, 0 summaries outside 1-120 characters or containing a newline. Not verified: cargo test -p codewhale-tui --test feature_registry (a tui test build; the only reported problem was the summary length), hosted CI. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
This commit is contained in:
1 parent
134dadc7bb
commit
46aa86634d
2 files changed
+3
-11
No files matched your search
@@ -750,18 +750,10 @@ assert.equal(
|
||||
2,
|
||||
"both glibc recovery branches must name codewhale-cli",
|
||||
);
|
||||
// The archive installer never overwrites an existing command: it validates the
|
||||
// retired TUI path against the consolidated bytes and leaves upgrades to
|
||||
// `codewhale update`, which migrates `codewhale-tui` beside the canonical pair.
|
||||
assert.match(
|
||||
archiveInstaller,
|
||||
/legacy_tui="\$BIN_DIR\/codewhale-tui"[\s\S]*check_destination "\$SCRIPT_DIR\/codewhale" "\$legacy_tui"/,
|
||||
"archive installs must validate the retired TUI path against consolidated bytes",
|
||||
);
|
||||
assert.doesNotMatch(
|
||||
archiveInstaller,
|
||||
/install_binary "\$SCRIPT_DIR\/codewhale" "\$legacy_tui"/,
|
||||
"archive installs must not overwrite an existing retired TUI command",
|
||||
/install_binary "\$SCRIPT_DIR\/[^"]+" "\$BIN_DIR\/codewhale-tui"/,
|
||||
"archive installs must not write the retired codewhale-tui command",
|
||||
);
|
||||
assert.doesNotMatch(
|
||||
cliDispatcher,
|
||||
|
||||
+1
-1
@@ -39,7 +39,7 @@
|
||||
[[feature]]
|
||||
id = "cloud-computer-dispatch"
|
||||
name = "Cloud computer conversations"
|
||||
summary = "Dispatch, inspect, continue and stop the same account cloud conversation from terminal and desktop, including conversations with a saved whale."
|
||||
summary = "Dispatch, inspect, continue and stop one account cloud conversation from terminal and desktop, saved whales included."
|
||||
status = "experimental"
|
||||
surfaces = { tui = "preview" }
|
||||
since = "unreleased"
|
||||
|
||||
Reference in new issue
Block a user