Merge pull request #7223 from asto18089/up/verify-retired-pointer

fix(tools): stop the verify description from teaching the hidden run_verifiers name
This commit is contained in:
Hunter Bown authored and GitHub committed 2026-11-06 09:14:38 +08:00
commit d4fc3646c5
2 files changed
+5 -1

No files matched your search

@@ -30,6 +30,8 @@ fn shared_prompt_text_names_only_callable_tools() {
/// The catalog is re-sent on every request, so a retired name in it is a
/// per-turn lie to every model. `verifier.rs` already guarded one such
/// description by hand; this covers the whole advertised surface at once.
/// `verify` joins the chain because its model-visible description
/// cross-references other tools, so everything it names must be callable.
#[test]
fn no_advertised_tool_teaches_a_retired_name() {
use crate::tools::registry::ToolRegistryBuilder;
@@ -44,6 +46,7 @@ fn no_advertised_tool_teaches_a_retired_name() {
.with_test_runner_tool()
.with_web_tools()
.with_patch_tools()
.with_verify_tool(None, "test-model".to_string())
.build(ToolContext::new(tmp.path().to_path_buf()));
for tool in registry.to_api_tools() {
+2 -1
View File
@@ -318,7 +318,8 @@ elevated reasoning and tries to REFUTE it, returning structured findings (issue,
suggested fix). Call this when it is worth spending extra thinking: before claiming a non-trivial \
change complete, after a risky or subtle edit, or when you are unsure the change fully satisfies \
the requirement and handles edge cases. Skip it for trivial or mechanical changes. This is not a \
test runner (use run_verifiers) or a code review of an arbitrary target (use review) — it is a \
test runner (use the Run tool with action=\"verifiers\") or a code review of an arbitrary \
target (use review) — it is a \
self-check of whether what you just did is actually correct and complete."
}