[PR #1] [MERGED] feat: add ROCm addon LXC helper script #8

New Issue

2026-06-05T16:29:06-04:00

yindo commented

2026-06-05 16:29:06 -04:00

📋 Pull Request Information

Original PR: https://github.com/Heretek-AI/ProxmoxVED/pull/1
Author: @BillyOutlast
Created: 3/8/2026
Status: ✅ Merged
Merged: 3/8/2026
Merged by: @BillyOutlast

Base: main ← Head: rocm-addon

📝 Commits (2)

68de6bc Add AMD ROCm addon configuration and installation script for Debian/Ubuntu LXC containers
927724e Merge branch 'community-unscripted:main' into rocm-addon

📊 Changes

2 files changed (+466 additions, -0 deletions)

View changed files

➕ frontend/public/json/rocm.json (+64 -0)
➕ tools/addon/rocm.sh (+402 -0)

📄 Description

✍️ Description

This PR adds a new AMD ROCm addon script for installing AMD ROCm (Radeon Open Compute) on Debian/Ubuntu LXC containers. The addon supports:

Debian 12 (bookworm) and Debian 13 (trixie)
Ubuntu 22.04 (jammy) and Ubuntu 24.04 (noble)
ROCm version 7.2

The script includes:

GPG key download and repository setup using deb822 format
Package installation with proper pinning
User group configuration (render, video)
Environment variable setup (PATH, LD_LIBRARY_PATH)
Uninstall and update functionality
Installation verification

Also includes frontend JSON metadata for the addon and updates the CI/CD workflow repository reference.

✅ Prerequisites (X in brackets)

Self-review completed – Code follows project standards.
Tested thoroughly – Changes work as expected.
No breaking changes – Existing functionality remains intact.
No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

🐞 Bug fix – Resolves an issue without breaking functionality.
✨ New feature – Adds new, non-breaking functionality.
💥 Breaking change – Alters existing functionality in a way that may require updates.
🆕 New script – A fully functional and tested script or script set.
🌍 Website update – Changes to website-related JSON files or metadata.
🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

Follows Code_Audit.md & CONTRIBUTING.md guidelines
Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
No hardcoded credentials

📋 Additional Information (optional)

The addon script is located at tools/addon/rocm.sh
JSON metadata at frontend/public/json/rocm.json
CI/CD workflow updated to reference the correct repository

📦 Application Requirements (for new scripts)

Required for 🆕 New script submissions.
Pull requests that do not meet these requirements may be closed without review.

The application is at least 6 months old
The application is actively maintained
The application has 600+ GitHub stars
Official release tarballs are published
I understand that not all scripts will be accepted due to various reasons and criteria by the community-scripts ORG

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Heretek-AI/ProxmoxVED/pull/1 **Author:** [@BillyOutlast](https://github.com/BillyOutlast) **Created:** 3/8/2026 **Status:** ✅ Merged **Merged:** 3/8/2026 **Merged by:** [@BillyOutlast](https://github.com/BillyOutlast) **Base:** `main` ← **Head:** `rocm-addon` --- ### 📝 Commits (2) - [`68de6bc`](https://github.com/Heretek-AI/ProxmoxVED/commit/68de6bcdecd9a048fc94ddc50f9577b972646721) Add AMD ROCm addon configuration and installation script for Debian/Ubuntu LXC containers - [`927724e`](https://github.com/Heretek-AI/ProxmoxVED/commit/927724e89a27c90c08e395ddc320959604fac735) Merge branch 'community-unscripted:main' into rocm-addon ### 📊 Changes **2 files changed** (+466 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `frontend/public/json/rocm.json` (+64 -0) ➕ `tools/addon/rocm.sh` (+402 -0) </details> ### 📄 Description ## ✍️ Description This PR adds a new AMD ROCm addon script for installing AMD ROCm (Radeon Open Compute) on Debian/Ubuntu LXC containers. The addon supports: - Debian 12 (bookworm) and Debian 13 (trixie) - Ubuntu 22.04 (jammy) and Ubuntu 24.04 (noble) - ROCm version 7.2 The script includes: - GPG key download and repository setup using deb822 format - Package installation with proper pinning - User group configuration (render, video) - Environment variable setup (PATH, LD_LIBRARY_PATH) - Uninstall and update functionality - Installation verification Also includes frontend JSON metadata for the addon and updates the CI/CD workflow repository reference. ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No breaking changes** – Existing functionality remains intact. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [x] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- ## 🔍 Code & Security Review (**X** in brackets) - [x] **Follows `Code_Audit.md` & `CONTRIBUTING.md` guidelines** - [x] **Uses correct script structure (`AppName.sh`, `AppName-install.sh`, `AppName.json`)** - [x] **No hardcoded credentials** ## 📋 Additional Information (optional) - The addon script is located at [`tools/addon/rocm.sh`](tools/addon/rocm.sh) - JSON metadata at [`frontend/public/json/rocm.json`](frontend/public/json/rocm.json) - CI/CD workflow updated to reference the correct repository --- ## 📦 Application Requirements (for new scripts) > Required for **🆕 New script** submissions. > Pull requests that do not meet these requirements may be closed without review. - [x] The application is **at least 6 months old** - [x] The application is **actively maintained** - [x] The application has **600+ GitHub stars** - [x] Official **release tarballs** are published - [x] I understand that not all scripts will be accepted due to various reasons and criteria by the community-scripts ORG --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-06-05 16:29:06 -04:00

yindo closed this issue

2026-06-05 16:29:06 -04:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: community-unscripted/ProxmoxVED#8