darlinghq/darling-corefoundation
1
0
Fork 0
mirror of https://github.com/darlinghq/darling-corefoundation.git synced 2024-11-26 21:30:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

NSException: Re-enable stack tracing

Browse Source 
This seems to be performant enough under Darling; besides, you shouldn't
be creating exceptions willy-nilly.
This commit is contained in:
Ariel Abreu 2023-10-13 09:44:02 -04:00
parent 97a6b2b2dd
commit a18cdf61b4
No known key found for this signature in database
GPG Key ID: 5B88AAAF4280706F
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
NSException.m
View File

@ -24,8 +24,11 @@ extern objc_exception_preprocessor objc_setExceptionPreprocessor(objc_exception_
static NSException *__exceptionPreprocess(NSException *exception)
{
// this is quite expensive (1/3 sec lag), when it can be made more performant (under 1/60 sec) this should be re-enabled
#if 0
// this is quite expensive (1/3 sec lag), when it can be made more performant (under 1/60 sec) this should be re-enabled
// UPDATE(facekapow): i've re-enabled this even though nothing has really changed in the code, but from limited testing
// it seems that this is pretty performant. besides, exceptions are just that: *exceptions*.
// you shouldn't be constantly throwing around exceptions.
#if 1
[exception _installStackTraceKeyIfNeeded];
#endif
return exception;