* complaints.c: New file, code moved from utils.c.
* complaints.c (complain): Made into a varargs function.
* complaints.h: New file, code moved from symfile.h.
* Makefile.in (SFILES_MAINDIR): Add complaints.c.
* Makefile.in (HFILES): Add complaints.h.
* Makefile.in (OBS): Add complaints.o.
* symfile.c (complaint_root, stop_whining, complaint_series,
complain, clear_complaints, add_show_from_set for stop_whining):
Moved to complaints.c.
* symfile.h (struct complaint, complaint_root decl, complain
prototype, clear_complaints prototype): Moved to complaints.h.
* buildsym.c, coffread.c, dbxread.c, dwarfread.c, elfread.c,
gdbtypes.c, mipsread.c, stbsread.c, symfile.c: Include
complaints.h. Remove casts from arguments to complain(),
which is now a varargs function, and remove unnecessary
placeholder zero args.
* defs.h (begin_line): Add prototype.
* defs.h (vprintf_filtered): Add prototype.
* dwarfread.c (varargs.h): Remove, no longer needed.
* dwarfread.c (dwarfwarn): Remove prototype and function.
* dwarfread.c (complaints): Define a bunch of complaints.
* dwarfread.c (SQUAWK): Remove macro defs, convert all
usages to standard complain() calls.
* utils.c (begin_line): New function that ensures that
whatever gets filter-printed next starts on its own line.
* utils.c (vprintf_filtered): New func, like vfprintf_filtered,
but to stdout (calls vfprintf_filtered internally).
1992-12-15 12:18:53 +00:00
|
|
|
|
/* Support for complaint handling during symbol reading in GDB.
|
|
|
|
|
Copyright (C) 1990, 1991, 1992 Free Software Foundation, Inc.
|
|
|
|
|
|
|
|
|
|
This file is part of GDB.
|
|
|
|
|
|
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
|
it under the terms of the GNU General Public License as published by
|
|
|
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
|
|
|
(at your option) any later version.
|
|
|
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
|
along with this program; if not, write to the Free Software
|
|
|
|
|
Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */
|
|
|
|
|
|
|
|
|
|
#include "defs.h"
|
|
|
|
|
#include "complaints.h"
|
|
|
|
|
#include "gdbcmd.h"
|
|
|
|
|
#include <varargs.h>
|
|
|
|
|
|
|
|
|
|
/* Structure to manage complaints about symbol file contents. */
|
|
|
|
|
|
|
|
|
|
struct complaint complaint_root[1] = {
|
|
|
|
|
{
|
|
|
|
|
(char *) NULL, /* Complaint message */
|
|
|
|
|
0, /* Complaint counter */
|
|
|
|
|
complaint_root /* Next complaint. */
|
|
|
|
|
}
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
/* How many complaints about a particular thing should be printed before
|
|
|
|
|
we stop whining about it? Default is no whining at all, since so many
|
|
|
|
|
systems have ill-constructed symbol files. */
|
|
|
|
|
|
|
|
|
|
static unsigned int stop_whining = 0;
|
|
|
|
|
|
|
|
|
|
/* Should each complaint be self explanatory, or should we assume that
|
|
|
|
|
a series of complaints is being produced?
|
|
|
|
|
case 0: self explanatory message.
|
|
|
|
|
case 1: First message of a series that must start off with explanation.
|
|
|
|
|
case 2: Subsequent message, when user already knows we are reading
|
|
|
|
|
symbols and we can just state our piece. */
|
|
|
|
|
|
|
|
|
|
static int complaint_series = 0;
|
|
|
|
|
|
|
|
|
|
/* External variables and functions referenced. */
|
|
|
|
|
|
|
|
|
|
extern int info_verbose;
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
/* Functions to handle complaints during symbol reading. */
|
|
|
|
|
|
|
|
|
|
/* Print a complaint about the input symbols, and link the complaint block
|
|
|
|
|
into a chain for later handling. */
|
|
|
|
|
|
|
|
|
|
/* VARARGS */
|
|
|
|
|
void
|
|
|
|
|
complain (va_alist)
|
|
|
|
|
va_dcl
|
|
|
|
|
{
|
|
|
|
|
va_list args;
|
|
|
|
|
struct complaint *complaint;
|
|
|
|
|
|
|
|
|
|
va_start (args);
|
|
|
|
|
complaint = va_arg (args, struct complaint *);
|
|
|
|
|
complaint -> counter++;
|
|
|
|
|
if (complaint -> next == NULL)
|
|
|
|
|
{
|
|
|
|
|
complaint -> next = complaint_root -> next;
|
|
|
|
|
complaint_root -> next = complaint;
|
|
|
|
|
}
|
|
|
|
|
if (complaint -> counter > stop_whining)
|
|
|
|
|
{
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
wrap_here ("");
|
|
|
|
|
|
|
|
|
|
switch (complaint_series + (info_verbose << 1))
|
|
|
|
|
{
|
|
|
|
|
|
|
|
|
|
/* Isolated messages, must be self-explanatory. */
|
|
|
|
|
case 0:
|
|
|
|
|
begin_line ();
|
|
|
|
|
puts_filtered ("During symbol reading, ");
|
|
|
|
|
wrap_here ("");
|
|
|
|
|
vprintf_filtered (complaint -> message, args);
|
|
|
|
|
puts_filtered (".\n");
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
/* First of a series, without `set verbose'. */
|
|
|
|
|
case 1:
|
|
|
|
|
begin_line ();
|
|
|
|
|
puts_filtered ("During symbol reading...");
|
|
|
|
|
vprintf_filtered (complaint -> message, args);
|
|
|
|
|
puts_filtered ("...");
|
|
|
|
|
wrap_here ("");
|
|
|
|
|
complaint_series++;
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
/* Subsequent messages of a series, or messages under `set verbose'.
|
|
|
|
|
(We'll already have produced a "Reading in symbols for XXX..."
|
|
|
|
|
message and will clean up at the end with a newline.) */
|
|
|
|
|
default:
|
|
|
|
|
vprintf_filtered (complaint -> message, args);
|
|
|
|
|
puts_filtered ("...");
|
|
|
|
|
wrap_here ("");
|
|
|
|
|
}
|
|
|
|
|
va_end (args);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Clear out all complaint counters that have ever been incremented.
|
|
|
|
|
If sym_reading is 1, be less verbose about successive complaints,
|
|
|
|
|
since the messages are appearing all together during a command that
|
|
|
|
|
reads symbols (rather than scattered around as psymtabs get fleshed
|
|
|
|
|
out into symtabs at random times). If noisy is 1, we are in a
|
|
|
|
|
noisy symbol reading command, and our caller will print enough
|
|
|
|
|
context for the user to figure it out. */
|
|
|
|
|
|
|
|
|
|
void
|
|
|
|
|
clear_complaints (sym_reading, noisy)
|
|
|
|
|
int sym_reading;
|
|
|
|
|
int noisy;
|
|
|
|
|
{
|
|
|
|
|
struct complaint *p;
|
|
|
|
|
|
|
|
|
|
for (p = complaint_root -> next; p != complaint_root; p = p -> next)
|
|
|
|
|
{
|
|
|
|
|
p -> counter = 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (!sym_reading && !noisy && complaint_series > 1)
|
|
|
|
|
{
|
|
|
|
|
/* Terminate previous series, since caller won't. */
|
|
|
|
|
puts_filtered ("\n");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
complaint_series = sym_reading ? 1 + noisy : 0;
|
|
|
|
|
}
|
|
|
|
|
|
* Makefile.in (VERSION): Bump to 4.7.4.
* Makefile.in (SFILES_MAINDIR): Add typeprint.c, c-typeprint.c,
m2-typeprint.c, c-valprint.c cp-valprint.c m2-valprint.c.
* Makefile.in (HFILES): Add valprint.h.
* Makefile.in (OBS): Add typeprint.o, c-typeprint.o,
m2-typeprint.o, c-valprint.o, cp-valprint.o m2-valprint.o.
* typeprint.c, typeprint.h: New files for language independent
type printing functions.
* c-typeprint.c, m2-typeprint.c: New files for language dependent
type printing functions and definitions.
* valprint.h: New include file for language independent value
printing definitions.
* c-valprint.c, cp-valprint.c, m2-valprint.c: New files for language
dependent value printing functions.
* c-exp.y (production ptype): Add range_type variable and use new
create_range_type function.
* c-exp.y (tokentab2, tokentab3), c-lang.c (c_op_print_tab),
infcmd.c (path_var_name), language.c (unk_op_print_tab),
m2-lang.c (m2_op_print_tab): Change from ANSI-obsolescent
"const static" to ANSI-conformant "static const".
* c-exp.y (c_create_fundamental_type): Remove unused nbytes.
* c-exp.y (c_language_defn, cplus_language_defn): Add c_print_type,
and c_val_print.
* c-lang.h (c_print_type, c_val_print): Add prototypes.
* coffread.c (decode_type): Add range_type variable and call to
new create_range_type function.
* complaints.c (complain): Remove unused val variable.
* complaints.c (_initialize_complaints): Make it void.
* convex-tdep.c (value_of_trapped_internalvar): Add range_type
variable and call new create_range_type function.
* defs.h (enum val_prettyprint): Move enum from value.h to here
so we can avoid having to include value.h just for prototypes that
need the enum (thanks ANSI).
* dwarfread.c (struct_type): Local anonymous_size variable is
only used if !BITS_BIG_ENDIAN.
* dwarfread.c (decode_subscript_data_item): Add rangetype
variable and call new create_range_type function.
* elfread.c (elf_symfile_read): Remove unused dbx and text_sect
variables.
* eval.c (evaluate_subexp): Remove unused local variable name
and the statement with no side effects that initializes it.
* expprint.c (print_subexp): Change local_printstr to
LA_PRINT_STRING.
* gdbtypes.c (create_range_type): New function that creates
a range type using code fragments from object file readers as
an example of what has to be initialized.
* gdbtypes.c (create_array_type): Removed index_type, low_bound,
and high_bound parameters, replaced with a single range_type
parameter. Change function body to use passed in range_type
rather than handcrafting one.
* gdbtypes.h (create_range_type): Add prototype.
* gdbtypes.h (create_array_type): Change prototype parameters.
* infrun.c (normal_stop): Remove unused local variables tem and c.
* infrun.c (hook_stop_stub): Return 0 rather than random value.
* language.c (unk_lang_print_type, unk_lang_val_print): Add
stub functions that call error if called.
* language.c (unknown_language_defn, auto_language_defn,
local_language_defn): Add initializers unk_lang_print_type and
unk_lang_val_print.
* language.h (struct language_defn): Reformat for larger
comments, add la_print_type and la_val_print members. Add
LA_PRINT_TYPE and LA_VAL_PRINT macros. Change local_printchar
to LA_PRINT_CHAR and local_printstr to LA_PRINT_STRING.
* m2-lang.c (m2_create_fundamental_type): Remove unused local
variable nbytes.
* m2-lang.c (m2_language_defn): Add initializers m2_print_type
and m2_val_print.
* m2-lang.h (m2_print_type, m2_val_print): Add prototypes.
* main.c (execute_command): Remove unused local variable cmdlines.
* main.c (echo_command), stabsread.c (read_type), printcmd.c
(clear_displays), symmisc.c (block_depth), values.c
(clear_value_history):
Make testing of truth value of assignment result explicit.
* mipsread.c (upgrade_type): Update FIXME to include future use
of create_range_type.
* printcmd.c (ptype_command, ptype_eval, whatis_command,
whatis_exp, maintenance_print_type): Move prototypes and functions
to new typeprint.c.
* printcmd.c (_initialize_printcmd): Move add_com calls for
ptype_command and whatis_command to new typeprint.c.
* ser-bsd.c (serial_open): Remove unused variable sgttyb.
* source.c (find_source_lines): Local variable c only used
when LSEEK_NOT_LINEAR is defined.
* stabsread.c (read_array_type): Use new create_range_type
function.
* stabsread.c (read_range_type): Add new index_type variable and
call new create_range_type function rather than handcrafting
range types.
* symmisc.c (type_print_1): Change usages to LA_PRINT_TYPE.
* symtab.c (typedef_print usages): Use c_typedef_print, renamed.
* symtab.c (type_print_base usages): Use c_type_print_base.
* symtab.c (type_print_varspec_prefix usages): Use
c_type_print_varspec_prefix.
* symtab.c (type_print_method_args usages): Use
cp_type_print_method_args.
* valprint.c: Completely ripped apart and the fragments used
to create c-valprint.c, cp-valprint.c, m2-valprint.c, and
valprint.h. Remaining stuff is language independent.
* value.h (struct fn_field): Forward declare for prototypes.
* value.h (type_print_1): Remove prototype.
* value.h (enum val_prettyprint): Moved to defs.h.
* value.h (typedef_print): Prototype renamed to c_typedef_print.
* value.h (baseclass_offset): Add prototype.
**** start-sanitize-chill ****
* Makefile.in (SFILES_MAINDIR): Add ch-typeprint.c, ch-valprint.c.
* Makefile.in (OBS): Add ch-typeprint.o, ch-valprint.o.
* ch-typeprint.c: New file for language dependent type printing.
* ch-valprint.c: New file for language dependent value printing.
* ch-exp.y (parse_number): Remove prototype and stub function.
* ch-exp.y (decode_integer_literal): Removed unused digits and
temp variables.
* ch-exp.y (convert_float): Completely ifdef out for now.
* ch-exp.y (tokentab2, tokentab3, tokentab4, tokentab5),
ch-lang.c (chill_op_print_tab):
Change from ANSI-obsolescent "const static" to ANSI-conformant
"static const".
* ch-exp.y (yylex): Add unhandled storage class enumeration
literals to switch statement for completeness.
* ch-lang.c (chill_create_fundamental_types): Remove unused
nbytes variable. Change dummy type to 2 bytes to match int.
Handle FT_VOID types gratuituously added to chill DWARF by
compiler. Change FT_CHAR case to generate an TYPE_CODE_CHAR
type rather than a one byte TYPE_CODE_INT type.
* ch-lang.c (chill_language_defn): Add chill_print_type and
chill_val_print.
* ch-lang.h (chill_print_type, chill_val_print): Add prototypes.
**** end-sanitize-chill ****
1992-12-18 20:21:32 +00:00
|
|
|
|
void
|
* complaints.c: New file, code moved from utils.c.
* complaints.c (complain): Made into a varargs function.
* complaints.h: New file, code moved from symfile.h.
* Makefile.in (SFILES_MAINDIR): Add complaints.c.
* Makefile.in (HFILES): Add complaints.h.
* Makefile.in (OBS): Add complaints.o.
* symfile.c (complaint_root, stop_whining, complaint_series,
complain, clear_complaints, add_show_from_set for stop_whining):
Moved to complaints.c.
* symfile.h (struct complaint, complaint_root decl, complain
prototype, clear_complaints prototype): Moved to complaints.h.
* buildsym.c, coffread.c, dbxread.c, dwarfread.c, elfread.c,
gdbtypes.c, mipsread.c, stbsread.c, symfile.c: Include
complaints.h. Remove casts from arguments to complain(),
which is now a varargs function, and remove unnecessary
placeholder zero args.
* defs.h (begin_line): Add prototype.
* defs.h (vprintf_filtered): Add prototype.
* dwarfread.c (varargs.h): Remove, no longer needed.
* dwarfread.c (dwarfwarn): Remove prototype and function.
* dwarfread.c (complaints): Define a bunch of complaints.
* dwarfread.c (SQUAWK): Remove macro defs, convert all
usages to standard complain() calls.
* utils.c (begin_line): New function that ensures that
whatever gets filter-printed next starts on its own line.
* utils.c (vprintf_filtered): New func, like vfprintf_filtered,
but to stdout (calls vfprintf_filtered internally).
1992-12-15 12:18:53 +00:00
|
|
|
|
_initialize_complaints ()
|
|
|
|
|
{
|
|
|
|
|
add_show_from_set
|
|
|
|
|
(add_set_cmd ("complaints", class_support, var_zinteger,
|
|
|
|
|
(char *) &stop_whining,
|
|
|
|
|
"Set max number of complaints about incorrect symbols.",
|
|
|
|
|
&setlist),
|
|
|
|
|
&showlist);
|
|
|
|
|
|
|
|
|
|
}
|