darlinghq/darling-gdb
1
0
Fork 0
mirror of https://github.com/darlinghq/darling-gdb.git synced 2024-12-12 14:37:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

record: fix instruction-history-size regression

Browse Source 
* record.c (command_size_to_target_size): Fix size comparison.
	Change parameter type from pointer to integer to integer.
	Update all users.
This commit is contained in:
Markus Metzger 2013-03-27 09:42:47 +00:00
parent 40653b3568
commit 0ccfeeae97
2 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2013-03-27 Markus Metzger <markus.t.metzger@intel.com>
* record.c (command_size_to_target_size): Fix size comparison.
Change parameter type from pointer to integer to integer.
Update all users.
2013-03-27 Pierre Muller <muller@sourceware.org>
* windows-nat.c (handle_output_debug_string): Avoid typecast

16
gdb/record.c
View File

@ -442,18 +442,18 @@ get_insn_history_modifiers (char **arg)
meaning unlimited. The target interfaces works with signed int
though, to indicate direction, so map "unlimited" to INT_MAX, which
is about the same as unlimited in practice. If the user does have
a log that huge, she can can fetch it in chunks across several
requests, but she'll likely have other problems first... */
a log that huge, she can fetch it in chunks across several requests,
but she'll likely have other problems first... */
static int
command_size_to_target_size (unsigned int *command)
command_size_to_target_size (unsigned int size)
{
gdb_assert (*command <= INT_MAX || *command == UINT_MAX);
gdb_assert (size <= INT_MAX || size == UINT_MAX);
if (record_call_history_size == UINT_MAX)
if (size == UINT_MAX)
return INT_MAX;
else
return *command;
return size;
}
/* The "record instruction-history" command. */
@ -467,7 +467,7 @@ cmd_record_insn_history (char *arg, int from_tty)
flags = get_insn_history_modifiers (&arg);
size = command_size_to_target_size (&record_insn_history_size);
size = command_size_to_target_size (record_insn_history_size);
if (arg == NULL || *arg == 0 || strcmp (arg, "+") == 0)
target_insn_history (size, flags);
@ -583,7 +583,7 @@ cmd_record_call_history (char *arg, int from_tty)
flags = get_call_history_modifiers (&arg);
size = command_size_to_target_size (&record_call_history_size);
size = command_size_to_target_size (record_call_history_size);
if (arg == NULL || *arg == 0 || strcmp (arg, "+") == 0)
target_call_history (size, flags);