darlinghq/darling-gdb
1
0
Fork 0
mirror of https://github.com/darlinghq/darling-gdb.git synced 2025-03-03 06:58:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

dwarf2read.c::read_subrange_type: Handle dynamic lower bounds

Browse Source 
Currently, read_subrange_type handles dynamicity only in the case of
the upper bound, and assumes that the lower bound is always static.
That's rooted in the fact that dynamicity was added to support C99
variable-length arrays, where the lower bound is always zero, and
therefore never dynamic.  But the lower bound can, in fact, be dynamic
in other languages such as Ada.

Consider for instance the following declaration in Ada...

    type Array_Type is array (L .. U) of Natural;

... where L and U are parameters of the function where the declaration
above was made, and whose value are 5 and 10.  Currently, the debugger
is able to print the value of the upper bound correctly, but not the
lower bound:

    (gdb) ptype array_type
    type = array (1 .. 10) of natural

After this patch, the debugger now prints:

    (gdb) ptype array_type
    type = array (5 .. 10) of natural

gdb/ChangeLog:

        * dwarf2read.c (read_subrange_type): Handle dynamic
        DW_AT_lower_bound attributes.
This commit is contained in:
Joel Brobecker 2014-04-19 20:41:56 -07:00
parent 8739bc53cd
commit 11c1ba7852
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2014-04-28 Joel Brobecker <brobecker@adacore.com>
* dwarf2read.c (read_subrange_type): Handle dynamic
DW_AT_lower_bound attributes.
2014-04-28 Joel Brobecker <brobecker@adacore.com>
* ada-lang.c (ada_discrete_type_high_bound): Resolve the type's

6
gdb/dwarf2read.c
View File

@ -14572,13 +14572,9 @@ read_subrange_type (struct die_info *die, struct dwarf2_cu *cu)
break;
}
/* FIXME: For variable sized arrays either of these could be
a variable rather than a constant value. We'll allow it,
but we don't know how to handle it. */
attr = dwarf2_attr (die, DW_AT_lower_bound, cu);
if (attr)
low.data.const_val
= dwarf2_get_attr_constant_value (attr, low.data.const_val);
attr_to_dynamic_prop (attr, die, cu, &low);
else if (!low_default_is_valid)
complaint (&symfile_complaints, _("Missing DW_AT_lower_bound "
"- DIE at 0x%x [in module %s]"),