Fix a problem in readelf where memcpy could be called with a NULL second argument.

* readelf.c (request_dump_bynumber): Only call memcpy if
	dump_sects is not NULL.
This commit is contained in:
Nick Clifton 2016-09-06 15:42:12 +01:00
parent bf1865065f
commit 21b65bac42
2 changed files with 11 additions and 3 deletions

View File

@ -1,3 +1,8 @@
2016-09-06 Nick Clifton <nickc@redhat.com>
* readelf.c (request_dump_bynumber): Only call memcpy if
dump_sects is not NULL.
2016-08-29 H.J. Lu <hongjiu.lu@intel.com>
* readelf.c (load_specific_debug_section): Check the external

View File

@ -4238,10 +4238,13 @@ request_dump_bynumber (unsigned int section, dump_type type)
error (_("Out of memory allocating dump request table.\n"));
else
{
/* Copy current flag settings. */
memcpy (new_dump_sects, dump_sects, num_dump_sects * sizeof (* dump_sects));
if (dump_sects)
{
/* Copy current flag settings. */
memcpy (new_dump_sects, dump_sects, num_dump_sects * sizeof (* dump_sects));
free (dump_sects);
free (dump_sects);
}
dump_sects = new_dump_sects;
num_dump_sects = section + 1;