darlinghq/darling-gdb
1
0
Fork 0
mirror of https://github.com/darlinghq/darling-gdb.git synced 2025-02-26 12:25:31 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Zero supplied stat buffers in functions that pretend to stat

Browse Source 
GDB has five places where it pretends to stat for bfd_openr_iovec.
Four of these only set the incoming buffer's st_size, leaving the
other fields unchanged, which is to say very likely populated with
random values from the stack.  remote_bfd_iovec_stat was fixed in
0a93529c56714b1da3d7106d3e0300764f8bb81c; this commit fixes the
other four.

gdb/ChangeLog:

	* jit.c (mem_bfd_iovec_stat): Zero supplied buffer.
	* minidebug.c (lzma_stat): Likewise.
	* solib-spu.c (spu_bfd_iovec_stat): Likewise.
	* spu-linux-nat.c (spu_bfd_iovec_stat): Likewise.
This commit is contained in:
Gary Benson 2015-04-14 12:35:30 +01:00
parent 889c2a6796
commit 326a5c7e36
5 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/ChangeLog
View File

@ -1,3 +1,10 @@
2015-04-14 Gary Benson <gbenson@redhat.com>
* jit.c (mem_bfd_iovec_stat): Zero supplied buffer.
* minidebug.c (lzma_stat): Likewise.
* solib-spu.c (spu_bfd_iovec_stat): Likewise.
* spu-linux-nat.c (spu_bfd_iovec_stat): Likewise.
2015-04-13 Stan Shebs <stanshebs@google.com>
* MAINTAINERS: Update my email address.

1
gdb/jit.c
View File

@ -126,6 +126,7 @@ mem_bfd_iovec_stat (struct bfd *abfd, void *stream, struct stat *sb)
{
struct target_buffer *buffer = (struct target_buffer*) stream;
memset (sb, 0, sizeof (struct stat));
sb->st_size = buffer->size;
return 0;
}

1
gdb/minidebug.c
View File

@ -241,6 +241,7 @@ lzma_stat (struct bfd *abfd,
{
struct gdb_lzma_stream *lstream = stream;
memset (sb, 0, sizeof (struct stat));
sb->st_size = lzma_index_uncompressed_size (lstream->index);
return 0;
}

1
gdb/solib-spu.c
View File

@ -313,6 +313,7 @@ spu_bfd_iovec_stat (bfd *abfd, void *stream, struct stat *sb)
table to find the extent of the last section but that seems
pointless when the size is needed only for checks of other
parsed values in dbxread.c. */
memset (sb, 0, sizeof (struct stat));
sb->st_size = INT_MAX;
return 0;
}

1
gdb/spu-linux-nat.c
View File

@ -313,6 +313,7 @@ spu_bfd_iovec_stat (struct bfd *abfd, void *stream, struct stat *sb)
table to find the extent of the last section but that seems
pointless when the size is needed only for checks of other
parsed values in dbxread.c. */
memset (sb, 0, sizeof (struct stat));
sb->st_size = INT_MAX;
return 0;
}