darlinghq/darling-gdb
1
0
Fork 0
mirror of https://github.com/darlinghq/darling-gdb.git synced 2025-02-06 01:09:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use strtod instead of strtold in libiberty/d-demangle.c

Browse Source 
strtold is currently used to decode templates which have a floating-point
value encoded inside; but this routine is not available on some systems,
such as Solaris 2.9 for instance.

This patch fixes the issue by replace the use of strtold by strtod.
It reduces a bit the precision, but it should still remain acceptable
in most cases.

libiberty/ChangeLog:

        * d-demangle.c: Replace strtold with strtod in global comment.
        (strtold): Remove declaration.
        (strtod): New declaration.
        (dlang_parse_real): Declare value as double instead of long
        double.  Replace call to strtold by call to strtod.
        Update format in call to snprintf.
This commit is contained in:
Joel Brobecker 2014-10-14 12:47:43 -04:00
parent 89c7137fad
commit 5af04e20f6
2 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libiberty/ChangeLog
View File

@ -1,3 +1,12 @@
2014-10-16 Joel Brobecker <brobecker@adacore.com>
* d-demangle.c: Replace strtold with strtod in global comment.
(strtold): Remove declaration.
(strtod): New declaration.
(dlang_parse_real): Declare value as double instead of long
double. Replace call to strtold by call to strtod.
Update format in call to snprintf.
2014-09-26 Jason Merrill <jason@redhat.com> 2014-09-26 Jason Merrill <jason@redhat.com>
* cp-demangle.c (d_substitution): Handle abi tags on abbreviation. * cp-demangle.c (d_substitution): Handle abi tags on abbreviation.

10
libiberty/d-demangle.c
View File

@ -28,7 +28,7 @@ If not, see <http://www.gnu.org/licenses/>. */
/* This file exports one function; dlang_demangle. /* This file exports one function; dlang_demangle.
This file imports strtol and strtold for decoding mangled literals. */ This file imports strtol and strtod for decoding mangled literals. */
#ifdef HAVE_CONFIG_H #ifdef HAVE_CONFIG_H
#include "config.h" #include "config.h"
@ -44,7 +44,7 @@ If not, see <http://www.gnu.org/licenses/>. */
#include <stdlib.h> #include <stdlib.h>
#else #else
extern long strtol (const char *nptr, char **endptr, int base); extern long strtol (const char *nptr, char **endptr, int base);
extern long double strtold (const char *nptr, char **endptr); extern double strtod (const char *nptr, char **endptr);
#endif #endif
#include <demangle.h> #include <demangle.h>
@ -810,7 +810,7 @@ dlang_parse_real (string *decl, const char *mangled)
{ {
char buffer[64]; char buffer[64];
int len = 0; int len = 0;
long double value; double value;
char *endptr; char *endptr;
/* Handle NAN and +-INF. */ /* Handle NAN and +-INF. */
@ -877,12 +877,12 @@ dlang_parse_real (string *decl, const char *mangled)
/* Convert buffer from hexadecimal to floating-point. */ /* Convert buffer from hexadecimal to floating-point. */
buffer[len] = '\0'; buffer[len] = '\0';
value = strtold (buffer, &endptr); value = strtod (buffer, &endptr);
if (endptr == NULL || endptr != (buffer + len)) if (endptr == NULL || endptr != (buffer + len))
return NULL; return NULL;
len = snprintf (buffer, sizeof(buffer), "%#Lg", value); len = snprintf (buffer, sizeof(buffer), "%#g", value);
string_appendn (decl, buffer, len); string_appendn (decl, buffer, len);
return mangled; return mangled;
} }