darlinghq/darling-gdb
1
0
Fork 0
mirror of https://github.com/darlinghq/darling-gdb.git synced 2024-11-28 06:20:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Windows] run program with space in path to exe.

Browse Source 
The following works...

    % gdb c:\path to exe\foo.exe
    (gdb) start

... unless a file or directory called "c:\path" or "c:\path to" exist.
This is what happens in the latter case:

    (gdb) start
    [...]
    Error creating process C:\path to exe\foo.exe (error 193).

This is because we are calling CreateProcess (et al) without specifying
the lpApplicationName, so Windows determines the name of the executable
using the second argument, which is the entire command line.  This
command line is a space-separated list of tokens, so the space in
the path to the executable which potentially creates an ambiguity.
The ambiguity is automatically resolved unless we're in the situation
above.

The solution, as suggested by the MSDN documentation for CreateProcess
is to quote the executable name.

gdb/ChangeLog:

        * windows-nat.c (windows_create_inferior) [!__CYGWIN__]:
        New local variable args_len.
        Quote the name of the executable when computing the command line.
This commit is contained in:
Joel Brobecker 2012-10-24 13:40:16 +00:00
parent 96a6292179
commit 8f205f9c40
2 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2012-10-24 Joel Brobecker <brobecker@adacore.com>
* windows-nat.c (windows_create_inferior) [!__CYGWIN__]:
New local variable args_len.
Quote the name of the executable when computing the command line.
2012-10-23 Mark Kettenis <kettenis@gnu.org>
PR gdb/12796

12
gdb/windows-nat.c
View File

@ -2036,6 +2036,7 @@ windows_create_inferior (struct target_ops *ops, char *exec_file,
char shell[__PMAX]; /* Path to shell */
char *toexec;
char *args;
size_t args_len;
HANDLE tty;
char *w32env;
char *temp;
@ -2188,10 +2189,13 @@ windows_create_inferior (struct target_ops *ops, char *exec_file,
}
#else
toexec = exec_file;
args = alloca (strlen (toexec) + strlen (allargs) + 2);
strcpy (args, toexec);
strcat (args, " ");
strcat (args, allargs);
/* Build the command line, a space-separated list of tokens where
the first token is the name of the module to be executed.
To avoid ambiguities introduced by spaces in the module name,
we quote it. */
args_len = strlen (toexec) + 2 /* quotes */ + strlen (allargs) + 2;
args = alloca (args_len);
xsnprintf (args, args_len, "\"%s\" %s", toexec, allargs);
flags |= DEBUG_ONLY_THIS_PROCESS;