darlinghq/darling-gdb
1
0
Fork 0
mirror of https://github.com/darlinghq/darling-gdb.git synced 2024-11-27 14:00:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

* elf64-ppc.c (ppc64_elf_get_synthetic_symtab): Copy input

Browse Source 
symbol pointer arrays before modifying.
This commit is contained in:
Alan Modra 2004-08-28 08:54:34 +00:00
parent b91e2ae21e
commit a7535cf331
2 changed files with 28 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
bfd/ChangeLog
View File

@ -1,3 +1,8 @@
2004-08-28 Alan Modra <amodra@bigpond.net.au>
* elf64-ppc.c (ppc64_elf_get_synthetic_symtab): Copy input
symbol pointer arrays before modifying.
2004-08-28 Alan Modra <amodra@bigpond.net.au>
* bfd.c (bfd_get_synthetic_symtab): Pass counts and both symbol tables.

48
bfd/elf64-ppc.c
View File

@ -2645,18 +2645,19 @@ sym_exists_at (asymbol **syms, long lo, long hi, int id, bfd_vma value)
entry syms. */
static long
ppc64_elf_get_synthetic_symtab (bfd *abfd, long symcount, asymbol **syms,
long dynsymcount, asymbol **dynsyms,
ppc64_elf_get_synthetic_symtab (bfd *abfd,
long static_count, asymbol **static_syms,
long dyn_count, asymbol **dyn_syms,
asymbol **ret)
{
asymbol *s;
long i;
long count;
char *names;
long codesecsym, codesecsymend, secsymend, opdsymend;
long symcount, codesecsym, codesecsymend, secsymend, opdsymend;
asection *opd;
bfd_boolean relocatable = (abfd->flags & (EXEC_P | DYNAMIC)) == 0;
asymbol **sy = NULL;
asymbol **syms;
*ret = NULL;
@ -2664,29 +2665,27 @@ ppc64_elf_get_synthetic_symtab (bfd *abfd, long symcount, asymbol **syms,
if (opd == NULL)
return 0;
symcount = static_count;
if (!relocatable)
{
if (symcount != 0 && dynsymcount != 0)
{
/* Use both symbol tables. */
sy = bfd_malloc ((symcount + dynsymcount + 1) * sizeof (*syms));
if (sy == NULL)
return 0;
memcpy (sy, syms, symcount * sizeof (*syms));
memcpy (sy + symcount, dynsyms, (dynsymcount + 1) * sizeof (*syms));
syms = sy;
symcount = symcount + dynsymcount;
}
else if (symcount == 0)
{
syms = dynsyms;
symcount = dynsymcount;
}
}
symcount += dyn_count;
if (symcount == 0)
return 0;
syms = bfd_malloc ((symcount + 1) * sizeof (*syms));
if (syms == NULL)
return 0;
if (!relocatable && static_count != 0 && dyn_count != 0)
{
/* Use both symbol tables. */
memcpy (syms, static_syms, static_count * sizeof (*syms));
memcpy (syms + static_count, dyn_syms, (dyn_count + 1) * sizeof (*syms));
}
else if (!relocatable && static_count == 0)
memcpy (syms, dyn_syms, (symcount + 1) * sizeof (*syms));
else
memcpy (syms, static_syms, (symcount + 1) * sizeof (*syms));
synthetic_opd = opd;
synthetic_relocatable = relocatable;
qsort (syms, symcount, sizeof (asymbol *), compare_symbols);
@ -2916,8 +2915,7 @@ ppc64_elf_get_synthetic_symtab (bfd *abfd, long symcount, asymbol **syms,
}
done:
if (sy != NULL)
free (sy);
free (syms);
return count;
}