darlinghq/darling-gdb
1
0
Fork 0
mirror of https://github.com/darlinghq/darling-gdb.git synced 2025-02-19 09:02:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

argv.c (expandargv): Check for directories passed as @-files.

Browse Source 
gcc pr 78584
This commit is contained in:
DJ Delorie 2016-12-06 01:40:44 -05:00
parent e99f7af2bf
commit fc72affa68
2 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libiberty/ChangeLog
View File

@ -1,3 +1,7 @@
2016-12-06 DJ Delorie <dj@redhat.com>
* argv.c (expandargv): Check for directories passed as @-files.
2016-11-03 David Tolnay <dtolnay@gmail.com> 2016-11-03 David Tolnay <dtolnay@gmail.com>
Mark Wielaard <mark@klomp.org> Mark Wielaard <mark@klomp.org>

19
libiberty/argv.c
View File

@ -35,6 +35,13 @@ Boston, MA 02110-1301, USA. */
#include <string.h> #include <string.h>
#include <stdlib.h> #include <stdlib.h>
#include <stdio.h> #include <stdio.h>
#include <sys/types.h>
#ifdef HAVE_UNISTD_H
#include <unistd.h>
#endif
#if HAVE_SYS_STAT_H
#include <sys/stat.h>
#endif
#ifndef NULL #ifndef NULL
#define NULL 0 #define NULL 0
@ -387,6 +394,9 @@ expandargv (int *argcp, char ***argvp)
char **file_argv; char **file_argv;
/* The number of options read from the response file, if any. */ /* The number of options read from the response file, if any. */
size_t file_argc; size_t file_argc;
#ifdef S_ISDIR
struct stat sb;
#endif
/* We are only interested in options of the form "@file". */ /* We are only interested in options of the form "@file". */
filename = (*argvp)[i]; filename = (*argvp)[i];
if (filename[0] != '@') if (filename[0] != '@')
@ -397,6 +407,15 @@ expandargv (int *argcp, char ***argvp)
fprintf (stderr, "%s: error: too many @-files encountered\n", (*argvp)[0]); fprintf (stderr, "%s: error: too many @-files encountered\n", (*argvp)[0]);
xexit (1); xexit (1);
} }
#ifdef S_ISDIR
if (stat (filename+1, &sb) < 0)
continue;
if (S_ISDIR(sb.st_mode))
{
fprintf (stderr, "%s: error: @-file refers to a directory\n", (*argvp)[0]);
xexit (1);
}
#endif
/* Read the contents of the file. */ /* Read the contents of the file. */
f = fopen (++filename, "r"); f = fopen (++filename, "r");
if (!f) if (!f)