darlinghq/darling-libcxx
1
0
Fork 0
mirror of https://github.com/darlinghq/darling-libcxx.git synced 2024-11-23 11:59:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add an off-by-default option to enable testing for gdb pretty printers.

Browse Source 
Summary:
The current version of the pretty printers are not python3 compatible,
so turn them off by default until sufficiently improved.

Reviewers: MaskRay, tamur

Subscribers: mgorny, christof, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D68477

git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@373796 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Sterling Augustine 2019-10-04 22:15:28 +00:00
parent 2f59751955
commit 09d641ffc2
2 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CMakeLists.txt
View File

@ -81,6 +81,7 @@ option(LIBCXX_ENABLE_FILESYSTEM "Build filesystem as part of the main libc++ lib
${ENABLE_FILESYSTEM_DEFAULT}) ${ENABLE_FILESYSTEM_DEFAULT})
option(LIBCXX_INCLUDE_TESTS "Build the libc++ tests." ${LLVM_INCLUDE_TESTS}) option(LIBCXX_INCLUDE_TESTS "Build the libc++ tests." ${LLVM_INCLUDE_TESTS})
option(LIBCXX_ENABLE_PARALLEL_ALGORITHMS "Enable the parallel algorithms library. This requires the PSTL to be available." OFF) option(LIBCXX_ENABLE_PARALLEL_ALGORITHMS "Enable the parallel algorithms library. This requires the PSTL to be available." OFF)
option(LIBCXX_TEST_GDB_PRETTY_PRINTERS "Test gdb pretty printers." OFF)
# Benchmark options ----------------------------------------------------------- # Benchmark options -----------------------------------------------------------
option(LIBCXX_INCLUDE_BENCHMARKS "Build the libc++ benchmarks and their dependencies" ON) option(LIBCXX_INCLUDE_BENCHMARKS "Build the libc++ benchmarks and their dependencies" ON)

16
test/CMakeLists.txt
View File

@ -60,12 +60,16 @@ if (NOT DEFINED LIBCXX_TEST_DEPS)
message(FATAL_ERROR "Expected LIBCXX_TEST_DEPS to be defined") message(FATAL_ERROR "Expected LIBCXX_TEST_DEPS to be defined")
endif() endif()
find_program(LIBCXX_GDB gdb) # Turn this on by default when the pretty printers are python3
if (LIBCXX_GDB) # compatible.
set(LIBCXX_GDB "${LIBCXX_GDB}") if(LIBCXX_TEST_GDB_PRETTY_PRINTERS)
message(STATUS "gdb found: ${LIBCXX_GDB}") find_program(LIBCXX_GDB gdb)
else() if (LIBCXX_GDB)
message(STATUS "gdb not found. Disabling dependent tests.") set(LIBCXX_GDB "${LIBCXX_GDB}")
message(STATUS "gdb found: ${LIBCXX_GDB}")
else()
message(STATUS "gdb not found. Disabling dependent tests.")
endif()
endif() endif()
if (LIBCXX_INCLUDE_TESTS) if (LIBCXX_INCLUDE_TESTS)