From ad935d583d1775c96ca1ebb3644eccbf531949d0 Mon Sep 17 00:00:00 2001 From: Howard Hinnant Date: Mon, 16 May 2011 19:05:11 +0000 Subject: [PATCH] Brought call_once variadic call up to current spec, which allows move-only functors and move-only arguments, but disallows functors with non-const lvalue reference parameters. git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@131414 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/mutex | 45 +++++++++++++++++-- .../thread.once.callonce/call_once.pass.cpp | 20 +++++++++ 2 files changed, 61 insertions(+), 4 deletions(-) diff --git a/include/mutex b/include/mutex index 21d38342d..fcfe4b71d 100644 --- a/include/mutex +++ b/include/mutex @@ -175,6 +175,9 @@ template #include <__config> #include <__mutex_base> #include +#ifndef _LIBCPP_HAS_NO_VARIADICS +#include +#endif #pragma GCC system_header @@ -455,6 +458,39 @@ private: #endif // _LIBCPP_HAS_NO_VARIADICS }; +#ifndef _LIBCPP_HAS_NO_VARIADICS + +template +class __call_once_param +{ + _F __f_; +public: +#ifndef _LIBCPP_HAS_NO_RVALUE_REFERENCES + _LIBCPP_INLINE_VISIBILITY + explicit __call_once_param(_F&& __f) : __f_(_STD::move(__f)) {} +#else + _LIBCPP_INLINE_VISIBILITY + explicit __call_once_param(const _F& __f) : __f_(__f) {} +#endif + + _LIBCPP_INLINE_VISIBILITY + void operator()() + { + typedef typename __make_tuple_indices::value, 1>::type _Index; + __execute(_Index()); + } + +private: + template + _LIBCPP_INLINE_VISIBILITY + void __execute(__tuple_indices<_Indices...>) + { + _STD::move(_STD::get<0>(__f_))(_STD::move(_STD::get<_Indices>(__f_))...); + } +}; + +#else + template class __call_once_param { @@ -475,6 +511,8 @@ public: } }; +#endif + template void __call_once_proxy(void* __vp) @@ -494,10 +532,9 @@ call_once(once_flag& __flag, _Callable&& __func, _Args&&... __args) { if (__builtin_expect(__flag.__state_ , ~0ul) != ~0ul) { - typedef decltype(std::bind(std::forward<_Callable>(__func), - std::forward<_Args>(__args)...)) _G; - __call_once_param<_G> __p(std::bind(std::forward<_Callable>(__func), - std::forward<_Args>(__args)...)); + typedef tuple::type, typename decay<_Args>::type...> _G; + __call_once_param<_G> __p(_G(__decay_copy(_STD::forward<_Callable>(__func)), + __decay_copy(_STD::forward<_Args>(__args))...)); __call_once(__flag.__state_, &__p, &__call_once_proxy<_G>); } } diff --git a/test/thread/thread.mutex/thread.once/thread.once.callonce/call_once.pass.cpp b/test/thread/thread.mutex/thread.once/thread.once.callonce/call_once.pass.cpp index 68ee43946..b4f76b45c 100644 --- a/test/thread/thread.mutex/thread.once/thread.once.callonce/call_once.pass.cpp +++ b/test/thread/thread.mutex/thread.once/thread.once.callonce/call_once.pass.cpp @@ -129,6 +129,22 @@ void f42() std::call_once(flg41, init41); } +#ifndef _LIBCPP_HAS_NO_VARIADICS + +class MoveOnly +{ + MoveOnly(const MoveOnly&); +public: + MoveOnly() {} + MoveOnly(MoveOnly&&) {} + + void operator()(MoveOnly&&) + { + } +}; + +#endif + int main() { // check basic functionality @@ -174,5 +190,9 @@ int main() t1.join(); assert(init2::called == 5); } + { + std::once_flag f; + std::call_once(f, MoveOnly(), MoveOnly()); + } #endif // _LIBCPP_HAS_NO_VARIADICS }