darlinghq/darling-libcxx
1
0
Fork 0
mirror of https://github.com/darlinghq/darling-libcxx.git synced 2024-11-30 07:10:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

More of P0600 - '[[nodiscard]] in the Library' mark empty() as nodiscard in filesystem::path

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@318378 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Marshall Clow 2017-11-16 05:48:32 +00:00
parent 79f3f9dbed
commit bc6989bcbd
3 changed files with 32 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
include/experimental/filesystem
View File

@ -972,7 +972,8 @@ public:
_LIBCPP_INLINE_VISIBILITY path extension() const { return string_type(__extension()); }
// query
_LIBCPP_INLINE_VISIBILITY bool empty() const _NOEXCEPT { return __pn_.empty(); }
_LIBCPP_NODISCARD_AFTER_CXX17 _LIBCPP_INLINE_VISIBILITY
bool empty() const _NOEXCEPT { return __pn_.empty(); }
_LIBCPP_INLINE_VISIBILITY bool has_root_name() const { return !__root_name().empty(); }
_LIBCPP_INLINE_VISIBILITY bool has_root_directory() const { return !__root_directory().empty(); }

28
test/std/experimental/filesystem/class.path/path.member/path.decompose/empty.fail.cpp Normal file
View File

@ -0,0 +1,28 @@
// -*- C++ -*-
//===----------------------------------------------------------------------===//
//
// The LLVM Compiler Infrastructure
//
// This file is dual licensed under the MIT and the University of Illinois Open
// Source Licenses. See LICENSE.TXT for details.
//
//===----------------------------------------------------------------------===//
// <experimental/filesystem>
// class path
// bool empty() const noexcept;
// UNSUPPORTED: c++98, c++03, c++11, c++14, c++17
// UNSUPPORTED: clang-3.3, clang-3.4, clang-3.5, clang-3.6, clang-3.7, clang-3.8
#include <experimental/filesystem>
#include "test_macros.h"
int main ()
{
std::experimental::filesystem::path c;
c.empty(); // expected-error {{ignoring return value of function declared with 'nodiscard' attribute}}
}

3
test/std/experimental/filesystem/class.path/path.member/path.decompose/path.decompose.pass.cpp
View File

@ -177,7 +177,8 @@ void decompFilenameTest()
for (auto const & TC : FilenameTestCases) {
path p(TC.raw);
assert(p == TC.raw);
ASSERT_NOEXCEPT(p.empty());
assert(p.filename() == TC.filename);
assert(p.has_filename() != TC.filename.empty());