darlinghq/darlingserver
1
0
Fork 0
mirror of https://github.com/darlinghq/darlingserver.git synced 2024-11-23 04:19:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

GetExecutablePath: Write the path out to the correct process

Browse Source 
We were writing out the path to the target process (i.e. the one we're
looking up), but we should instead write it out to the process who made
the call.
This commit is contained in:
Ariel Abreu 2022-05-19 15:21:32 -04:00
parent 2d64a44c85
commit 814434f139
No known key found for this signature in database
GPG Key ID: D67AE16CCEA85B70
1 changed files with 18 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/call.cpp
View File

@ -950,17 +950,26 @@ void DarlingServer::Call::GetExecutablePath::processCall() {
int code = 0;
uint64_t fullLength;
if (auto maybeTargetProcess = processRegistry().lookupEntryByNSID(_body.pid)) {
auto targetProcess = *maybeTargetProcess;
auto path = targetProcess->executablePath();
auto len = std::min(path.length() + 1, _body.buffer_size);
if (!targetProcess->writeMemory((uintptr_t)_body.buffer, path.data(), len, &code)) {
code = -code;
if (auto callingThread = _thread.lock()) {
if (auto callingProcess = callingThread->process()) {
if (auto maybeTargetProcess = processRegistry().lookupEntryByNSID(_body.pid)) {
auto targetProcess = *maybeTargetProcess;
auto path = targetProcess->executablePath();
auto len = std::min(path.length() + 1, _body.buffer_size);
if (!callingProcess->writeMemory((uintptr_t)_body.buffer, path.c_str(), len, &code)) {
code = -code;
}
fullLength = path.length();
} else {
// not negated because this is an acceptable case.
// e.g. the target process may have died before the call was processed.
code = ESRCH;
}
} else {
code = -ESRCH;
}
fullLength = path.length();
} else {
code = ESRCH;
code = -ESRCH;
}
_sendReply(code, fullLength);