From 82120babf7fe2345275b4bcfc15129660180a008 Mon Sep 17 00:00:00 2001 From: Grant Paul Date: Sat, 13 Aug 2016 23:48:10 -0700 Subject: [PATCH] Remove operators and hash specialization for archive attribute lists. These methods were unused and they made the attribute list more complex. --- Libraries/libcar/Headers/car/AttributeList.h | 14 -------------- Libraries/libcar/Sources/AttributeList.cpp | 19 ------------------- 2 files changed, 33 deletions(-) diff --git a/Libraries/libcar/Headers/car/AttributeList.h b/Libraries/libcar/Headers/car/AttributeList.h index 37b3115b..2cb991b6 100644 --- a/Libraries/libcar/Headers/car/AttributeList.h +++ b/Libraries/libcar/Headers/car/AttributeList.h @@ -39,10 +39,6 @@ private: public: AttributeList(std::unordered_map const &values); -public: - bool operator==(AttributeList const &rhs) const; - bool operator!=(AttributeList const &rhs) const; - public: /* * Get the value of an attribute. @@ -104,14 +100,4 @@ public: } -namespace std { -template<> struct hash -{ - /* - * Suport using an AttributeList as a key. - */ - size_t operator()(car::AttributeList const &attributes) const; -}; -} - #endif /* _LIBCAR_ATTRIBUTELIST_H */ diff --git a/Libraries/libcar/Sources/AttributeList.cpp b/Libraries/libcar/Sources/AttributeList.cpp index b189071b..a1d6c1b0 100644 --- a/Libraries/libcar/Sources/AttributeList.cpp +++ b/Libraries/libcar/Sources/AttributeList.cpp @@ -17,18 +17,6 @@ AttributeList(std::unordered_map const { } -bool AttributeList:: -operator==(AttributeList const &rhs) const -{ - return _values == rhs._values; -} - -bool AttributeList:: -operator!=(AttributeList const &rhs) const -{ - return !(*this == rhs); -} - ext::optional AttributeList:: get(enum car_attribute_identifier identifier) const { @@ -88,13 +76,6 @@ Load(size_t count, struct car_attribute_pair const *pairs) return AttributeList(attributes); } -size_t std::hash:: -operator()(AttributeList const &attributes) const -{ - /* Not a great hash. */ - return attributes.count(); -} - std::vector AttributeList:: write(size_t count, uint32_t const *identifiers) const {