mirror of
https://github.com/deepset-ai/haystack.git
synced 2026-10-12 02:12:50 +00:00
Krishna Chaitanyaandbogdankostic
948f21b02e
* chore: add type checking to test/tracing/, test/marshal/, and test/testing/ Partially addresses #10396 by extending mypy type checking to three more test directories. Fixes type errors including missing annotations on pytest fixtures, unhandled Optional returns from current_span(), incorrect generator fixture return types, and dynamic LogRecord attribute access. * address review comments from @bogdankostic * remove redundant assert tracer.current_span() is not None The assertion on current_span already covers this check. * replace getattr with direct attribute access (B009) The hasattr guard already ensures the attribute exists, so direct access is safe. Added type: ignore comments since LogRecord doesn't declare operation_name in its type stubs. * fix: address remaining PR review comments - Remove unnecessary type: ignore[attr-defined] where hasattr guards exist - Add type: ignore[func-returns-value] to delete_documents assertion * fix: reformat test_logging_tracer.py to pass fmt-check --------- Co-authored-by: bogdankostic <[email protected]>