diasurgical/DevilutionX
1
0
Fork 0
mirror of https://github.com/diasurgical/DevilutionX.git synced 2026-10-12 02:13:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

💨 Do not zero-initalize arrays we write to

Browse Source 
`std::make_unique<T[]>(size)` always zero-initalizes the array.

C++20 has `std::make_unique_for_overwrite` to avoid that, while
older C++ versions can use the approach applied here.
This commit is contained in:
Gleb Mazovetskiy
2021-05-02 05:52:11 +02:00
committed by Anders Jenbo
parent b177f77d21
commit f33f7ae7eb
9 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/encrypt.cpp
+4 -4
View File
@@ -97,13 +97,13 @@ static void PkwareBufferWrite(char *buf, unsigned int *size, void *param)
uint32_t PkwareCompress(uint8_t *srcData, uint32_t size)
{
auto ptr = std::make_unique<char[]>(CMP_BUFFER_SIZE);
std::unique_ptr<char[]> ptr { new char[CMP_BUFFER_SIZE] };
unsigned destSize = 2 * size;
if (destSize < 2 * 4096)
destSize = 2 * 4096;
auto destData = std::make_unique<uint8_t[]>(destSize);
std::unique_ptr<uint8_t[]> destData { new uint8_t[destSize] };
TDataInfo param;
param.srcData = srcData;
@@ -128,8 +128,8 @@ void PkwareDecompress(uint8_t *inBuff, int recvSize, int maxBytes)
{
TDataInfo info;
auto ptr = std::make_unique<char[]>(CMP_BUFFER_SIZE);
auto outBuff = std::make_unique<uint8_t[]>(maxBytes);
std::unique_ptr<char[]> ptr { new char[CMP_BUFFER_SIZE] };
std::unique_ptr<uint8_t[]> outBuff { new uint8_t[maxBytes] };
info.srcData = inBuff;
info.srcOffset = 0;