mirror of
https://github.com/docker/compose.git
synced 2026-10-12 10:59:50 +00:00
Nicolas De Loof
0d206e6704
The previous fix only covered create/start. projectOrName backs every other service-targeting command too (stop, kill, pause, unpause, logs, rm, down, ps, events), so they still surfaced the same two problems: a raw "no such service" error for a job name, and -- when COMPOSE_PROJECT_NAME is set -- a silent no-op, since projectOrName's label-driven fallback swallows the load error entirely. Fold the check into projectOrName so every caller is fixed at once, instead of duplicating the wiring per command. start.go's own job-handling code, now redundant, is removed; jobTargetErr and unselectedJobs (cmd/compose/run.go) are unchanged, just called from one more place. Adds unit coverage for projectOrName itself (including the COMPOSE_PROJECT_NAME path and the typo-correlation edge case) and e2e coverage for two more callers (stop, down) to confirm the fix lives in the shared helper rather than being re-implemented per command. Signed-off-by: Nicolas De Loof <[email protected]>
11 lines
174 B
YAML
11 lines
174 B
YAML
services:
|
|
web:
|
|
image: alpine
|
|
command: sleep infinity
|
|
jobs:
|
|
migrate:
|
|
image: alpine
|
|
command: sh -c 'echo "migration done"'
|
|
triggers:
|
|
manual: true
|