mirror of
https://github.com/docker/compose.git
synced 2026-10-12 02:13:08 +00:00
Milas Bowman
3371227794
Unfortunately, the feature flag mechanism for experimental features isn't adequate. To avoid some edge cases where Compose might try to use Synchronized file shares with Desktop when the feature isn't available, we need to query a new endpoint. Before we move any of this out of experimental, we need to improve the integration here with Desktop & Compose so that we get all the necessary feature/experiment state up-front to reduce the quantity of IPC calls needed up-front. For now, there's some intentional redundancy to avoid making this extra call if we can avoid it. The actual endpoint is very cheap/ fast, but every IPC call is a potential point of of failure, so it's worth it. Signed-off-by: Milas Bowman <[email protected]>
49 lines
1.5 KiB
Go
49 lines
1.5 KiB
Go
/*
|
|
Copyright 2024 Docker Compose CLI authors
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package compose
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/docker/compose/v2/internal/desktop"
|
|
"github.com/docker/compose/v2/internal/experimental"
|
|
"github.com/sirupsen/logrus"
|
|
)
|
|
|
|
func (s *composeService) SetDesktopClient(cli *desktop.Client) {
|
|
s.desktopCli = cli
|
|
}
|
|
|
|
func (s *composeService) SetExperiments(experiments *experimental.State) {
|
|
s.experiments = experiments
|
|
}
|
|
|
|
func (s *composeService) manageDesktopFileSharesEnabled(ctx context.Context) bool {
|
|
// there's some slightly redundancy here to avoid fetching the config if
|
|
// we can already tell the feature state - in practice, we
|
|
if !s.isDesktopIntegrationActive() || !s.experiments.AutoFileShares() {
|
|
return false
|
|
}
|
|
|
|
fileSharesConfig, err := s.desktopCli.GetFileSharesConfig(ctx)
|
|
if err != nil {
|
|
logrus.Debugf("Failed to retrieve file shares config: %v", err)
|
|
return false
|
|
}
|
|
return fileSharesConfig.Active && fileSharesConfig.Compose.ManageBindMounts
|
|
}
|