mirror of
https://github.com/docker/compose.git
synced 2026-10-12 02:13:08 +00:00
Nicolas De Loof
7af58e3626
AGENTS.md documents 'Test unit: go test ./pkg/...' and 'E2E tests: go test -tags e2e ./pkg/e2e/'. Both statements were false: no file in pkg/e2e carried an e2e build constraint, so the -tags flag was a no-op and the 'unit' command actually launched the full e2e suite — requiring a Docker daemon and the locally built binary, creating and destroying containers, for up to 20 minutes. CI only avoided this by grepping e2e out of the package list (Dockerfile). Every *_test.go in pkg/e2e now carries //go:build e2e (merged with the existing !windows constraints), and the Makefile e2e targets pass the tag. The documented commands become true: - go test ./pkg/... -> pkg/e2e reports [no test files] - go test -tags e2e ./pkg/e2e -> runs the suite AGENTS.md now also states the daemon/binary prerequisites explicitly. Part of #14074 (A: the code misdescribes its own structure). Signed-off-by: Nicolas De Loof <[email protected]>
66 lines
2.4 KiB
Go
66 lines
2.4 KiB
Go
//go:build e2e
|
|
|
|
/*
|
|
Copyright 2020 Docker Compose CLI authors
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package e2e
|
|
|
|
import (
|
|
"regexp"
|
|
"testing"
|
|
)
|
|
|
|
// The build-once scenarios lock a regression where run built pull_policy:
|
|
// build dependencies twice — once in startDependencies and once in
|
|
// ensureImagesExists. Counting the "naming to ... done" build reports in the
|
|
// verbose output is the observable.
|
|
|
|
func builtOnce(project, service string) Check {
|
|
return OutputMatchesCount(`naming to .*`+regexp.QuoteMeta(project)+`-`+regexp.QuoteMeta(service)+`.* done`, 1)
|
|
}
|
|
|
|
func TestRunBuildOnceDependency(t *testing.T) {
|
|
s := NewScenario(t, "run --build must build a pull_policy: build dependency exactly once")
|
|
s.Defer(DockerCmd("image", "rm", "-f", s.Project()+"-nginx").MayFail()).
|
|
Step("run builds the dependency once and executes the service",
|
|
ComposeCmd("--verbose", "run", "--build", "--rm", "curl"),
|
|
builtOnce(s.Project(), "nginx"),
|
|
StdoutContains("curl service"))
|
|
}
|
|
|
|
func TestRunBuildOnceNestedDependencies(t *testing.T) {
|
|
s := NewScenario(t, "run --build must build each service of a dependency chain exactly once")
|
|
s.Defer(
|
|
DockerCmd("image", "rm", "-f", s.Project()+"-db").MayFail(),
|
|
DockerCmd("image", "rm", "-f", s.Project()+"-api").MayFail(),
|
|
DockerCmd("image", "rm", "-f", s.Project()+"-app").MayFail()).
|
|
Step("run builds the whole chain, each image once",
|
|
ComposeCmd("--verbose", "run", "--build", "--rm", "app"),
|
|
builtOnce(s.Project(), "db"),
|
|
builtOnce(s.Project(), "api"),
|
|
builtOnce(s.Project(), "app"),
|
|
StdoutContains("App running"))
|
|
}
|
|
|
|
func TestRunBuildOnceNoDeps(t *testing.T) {
|
|
s := NewScenario(t, "run --build on a dependency-less service must build it exactly once")
|
|
s.Defer(DockerCmd("image", "rm", "-f", s.Project()+"-simple").MayFail()).
|
|
Step("run builds the service once and executes it",
|
|
ComposeCmd("run", "--build", "--rm", "simple"),
|
|
builtOnce(s.Project(), "simple"),
|
|
StdoutContains("Simple service"))
|
|
}
|