mirror of
https://github.com/docker/compose.git
synced 2026-10-12 02:13:08 +00:00
Nicolas De Loof
7af58e3626
AGENTS.md documents 'Test unit: go test ./pkg/...' and 'E2E tests: go test -tags e2e ./pkg/e2e/'. Both statements were false: no file in pkg/e2e carried an e2e build constraint, so the -tags flag was a no-op and the 'unit' command actually launched the full e2e suite — requiring a Docker daemon and the locally built binary, creating and destroying containers, for up to 20 minutes. CI only avoided this by grepping e2e out of the package list (Dockerfile). Every *_test.go in pkg/e2e now carries //go:build e2e (merged with the existing !windows constraints), and the Makefile e2e targets pass the tag. The documented commands become true: - go test ./pkg/... -> pkg/e2e reports [no test files] - go test -tags e2e ./pkg/e2e -> runs the suite AGENTS.md now also states the daemon/binary prerequisites explicitly. Part of #14074 (A: the code misdescribes its own structure). Signed-off-by: Nicolas De Loof <[email protected]>
73 lines
2.6 KiB
Go
73 lines
2.6 KiB
Go
//go:build e2e
|
|
|
|
/*
|
|
Copyright 2020 Docker Compose CLI authors
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package e2e
|
|
|
|
import (
|
|
"testing"
|
|
)
|
|
|
|
// The pull command's report — Pulled vs Skipped — is the CLI's decision, so
|
|
// these scenarios legitimately observe the output.
|
|
|
|
func TestComposePull(t *testing.T) {
|
|
NewScenario(t, "pull must always pull, whether or not the image is present locally").
|
|
Step("start without the images in the local store",
|
|
ComposeCmd("down", "--rmi", "all")).
|
|
Step("pull fetches every service image",
|
|
ComposeCmd("pull"),
|
|
OutputContains("Image alpine:3.14 Pulled"),
|
|
OutputContains("Image alpine:3.15 Pulled")).
|
|
Step("pull again still pulls: the command's default policy is always",
|
|
ComposeCmd("pull"),
|
|
OutputContains("Image alpine:3.14 Pulled"),
|
|
OutputContains("Image alpine:3.15 Pulled"))
|
|
}
|
|
|
|
func TestPullImagePresentLocally(t *testing.T) {
|
|
NewScenario(t, "with pull_policy missing, a present image is skipped but a :latest tag is still pulled").
|
|
Step("warm the local store",
|
|
ComposeCmd("pull")).
|
|
Step("a second pull skips the pinned tag and refreshes latest",
|
|
ComposeCmd("pull"),
|
|
OutputContains("alpine:3.13.12 Skipped Image is already present locally"),
|
|
OutputContains("alpine:latest Pulled"))
|
|
}
|
|
|
|
func TestPullNoImageNameGiven(t *testing.T) {
|
|
NewScenario(t, "pull must skip a build-only service instead of failing").
|
|
Step("pull reports there is nothing to pull",
|
|
ComposeCmd("pull"),
|
|
OutputContains("Skipped No image to be pulled"))
|
|
}
|
|
|
|
func TestPullFailure(t *testing.T) {
|
|
NewScenario(t, "pull must fail when a service image cannot be pulled").
|
|
Step("pull reports the denied image and fails",
|
|
ComposeCmd("pull").MayFail(),
|
|
ExitCode(1),
|
|
OutputContains("pull access denied for does_not_exists"))
|
|
}
|
|
|
|
func TestPullIgnoreFailures(t *testing.T) {
|
|
NewScenario(t, "pull --ignore-pull-failures must succeed and point at the services to build").
|
|
Step("pull succeeds despite the missing image",
|
|
ComposeCmd("pull", "--ignore-pull-failures"),
|
|
OutputContains("Some service image(s) must be built from source by running:"))
|
|
}
|